Bug 96307 - Silence a warning when running update-webkit-localizable-strings
Summary: Silence a warning when running update-webkit-localizable-strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 13:20 PDT by Anders Carlsson
Modified: 2012-09-10 13:30 PDT (History)
0 users

See Also:

Attachments
Patch (2.08 KB, patch)
2012-09-10 13:21 PDT, Anders Carlsson 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-09-10 13:20:18 PDT 
Silence a warning when running update-webkit-localizable-strings
Comment 1 Anders Carlsson 2012-09-10 13:21:50 PDT 
Created attachment 163191 [details]
Patch
Comment 2 John Sullivan 2012-09-10 13:23:52 PDT 
Comment on attachment 163191 [details]
Patch

The other way to do this would be to make the two instances have identical localizer comments, as long as we are certain that there’s no chance that the two strings would be localized differently (taking context into account) in any language.
Comment 3 John Sullivan 2012-09-10 13:25:27 PDT 
Comment on attachment 163191 [details]
Patch

Oops, you also need to update Localizable.strings in this patch (you wouldn’t need to if you made the localizer comments the same).
Comment 4 John Sullivan 2012-09-10 13:28:25 PDT 
Comment on attachment 163191 [details]
Patch

r+ assuming you also check in the updated Localizable.strings
Comment 5 Anders Carlsson 2012-09-10 13:30:53 PDT 
Committed r128098: <http://trac.webkit.org/changeset/128098>