Bug 96305 - Rename computeLogicalHeight to updateLogicalHeight
Summary: Rename computeLogicalHeight to updateLogicalHeight
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 13:04 PDT by Tony Chang
Modified: 2012-09-11 10:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (32.72 KB, patch)
2012-09-10 13:05 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (32.79 KB, patch)
2012-09-10 15:12 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (32.78 KB, patch)
2012-09-11 09:56 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-09-10 13:04:25 PDT
Rename computeLogicalHeight to updateLogicalHeight
Comment 1 Tony Chang 2012-09-10 13:05:19 PDT
Created attachment 163184 [details]
Patch
Comment 2 Tony Chang 2012-09-10 13:06:04 PDT
Comment on attachment 163184 [details]
Patch

See 96288 for the computeLogicalWidth rename.
Comment 3 Tony Chang 2012-09-10 13:07:28 PDT
Comment on attachment 163184 [details]
Patch

I bet I'll have to rebase after the computeLogicalWidth patch lands.
Comment 4 Tony Chang 2012-09-10 15:12:05 PDT
Created attachment 163222 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-09-10 17:13:50 PDT
Comment on attachment 163222 [details]
Patch for landing

Rejecting attachment 163222 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
45>At revision 63.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13810418
Comment 6 Tony Chang 2012-09-11 09:56:15 PDT
Created attachment 163389 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-09-11 10:21:40 PDT
Comment on attachment 163389 [details]
Patch for landing

Clearing flags on attachment: 163389

Committed r128201: <http://trac.webkit.org/changeset/128201>
Comment 8 WebKit Review Bot 2012-09-11 10:21:44 PDT
All reviewed patches have been landed.  Closing bug.