Bug 96300 - [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined
Summary: [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66643
  Show dependency treegraph
 
Reported: 2012-09-10 12:24 PDT by Raul Hudea
Modified: 2012-09-19 11:50 PDT (History)
8 users (show)

See Also:


Attachments
Expose webkitRegionOverset only if CSS_REGIONS is enabled (3.25 KB, patch)
2012-09-19 01:19 PDT, Raul Hudea
no flags Details | Formatted Diff | Diff
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file) (3.36 KB, patch)
2012-09-19 04:44 PDT, Raul Hudea
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raul Hudea 2012-09-10 12:24:02 PDT
At least one in Element.idl, regionOverset is visible.
Comment 1 Raul Hudea 2012-09-19 01:19:45 PDT
Created attachment 164688 [details]
Expose webkitRegionOverset only if CSS_REGIONS is enabled
Comment 2 Raul Hudea 2012-09-19 04:44:02 PDT
Created attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)
Comment 3 Yury Semikhatsky 2012-09-19 08:02:56 PDT
Comment on attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review

> Source/WebCore/css/StyleRule.cpp:87
> +        ASSERT_NOT_REACHED();

Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable?
Comment 4 Raul Hudea 2012-09-19 08:08:42 PDT
(In reply to comment #3)
> (From update of attachment 164713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review
> 
> > Source/WebCore/css/StyleRule.cpp:87
> > +        ASSERT_NOT_REACHED();
> 
> Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable?

in that StyleRule.cpp, all 4 types (Unknown, Charset, Keyframe and Regions(when ) are unreachable in all other functions: createCSSOMWrapper(), destroy() and copy(). So, they should also trigger an assert in reportMemoryUsage. They are marked as "Not used" in StyleRule.h
Comment 5 WebKit Review Bot 2012-09-19 08:30:21 PDT
Comment on attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

Clearing flags on attachment: 164713

Committed r129009: <http://trac.webkit.org/changeset/129009>
Comment 6 WebKit Review Bot 2012-09-19 08:30:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Adam Barth 2012-09-19 11:50:50 PDT
Comment on attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review

> Source/WebCore/dom/Element.idl:146
> -        readonly attribute DOMString webkitRegionOverset;
> +        readonly attribute [Conditional=CSS_REGIONS] DOMString webkitRegionOverset;

Thanks!