Bug 96300 – [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Raul Hudea]

At least one in Element.idl, regionOverset is visible.

[Raul Hudea]

Created attachment 164688 [details]
Expose webkitRegionOverset only if CSS_REGIONS is enabled

[Raul Hudea]

Created attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

[Yury Semikhatsky]

Comment on attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review

> Source/WebCore/css/StyleRule.cpp:87
> +        ASSERT_NOT_REACHED();

Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable?

[Raul Hudea]

(In reply to comment #3)
> (From update of attachment 164713 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review
> 
> > Source/WebCore/css/StyleRule.cpp:87
> > +        ASSERT_NOT_REACHED();
> 
> Why did you remove the instrumentation for Unknow, Charset and Keyframe? Are they also unreachable?

in that StyleRule.cpp, all 4 types (Unknown, Charset, Keyframe and Regions(when ) are unreachable in all other functions: createCSSOMWrapper(), destroy() and copy(). So, they should also trigger an assert in reportMemoryUsage. They are marked as "Not used" in StyleRule.h

[WebKit Review Bot]

Comment on attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

Clearing flags on attachment: 164713

Committed r129009: <http://trac.webkit.org/changeset/129009>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

Comment on attachment 164713 [details]
Added an extra ASSERT_NOT_REACHED to reportMemoryUsage (similar to how other functions do inside this file)

View in context: https://bugs.webkit.org/attachment.cgi?id=164713&action=review

> Source/WebCore/dom/Element.idl:146
> -        readonly attribute DOMString webkitRegionOverset;
> +        readonly attribute [Conditional=CSS_REGIONS] DOMString webkitRegionOverset;

Thanks!