Bug 96289 - [V8] V8HTMLDocument::write and friends should not indirect through Frame
Summary: [V8] V8HTMLDocument::write and friends should not indirect through Frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 10:57 PDT by Adam Barth
Modified: 2012-09-10 13:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.21 KB, patch)
2012-09-10 10:59 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (4.21 KB, patch)
2012-09-10 11:14 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-10 10:57:40 PDT
[V8] V8HTMLDocument::write and friends should not indirect through Frame
Comment 1 Adam Barth 2012-09-10 10:59:06 PDT
Created attachment 163167 [details]
Patch
Comment 2 Kentaro Hara 2012-09-10 11:01:15 PDT
Comment on attachment 163167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163167&action=review

LGTM but I'd like to delegate the review to eric.

> Source/WebCore/ChangeLog:9
> +        throught the Frame to find the active document. This patch makes these

Nit: through
Comment 3 Adam Barth 2012-09-10 11:14:01 PDT
Created attachment 163169 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-09-10 11:14:55 PDT
Comment on attachment 163169 [details]
Patch

LGTM.
Comment 5 Adam Barth 2012-09-10 13:21:00 PDT
Comment on attachment 163169 [details]
Patch

Clearing flags on attachment: 163169

Committed r128095: <http://trac.webkit.org/changeset/128095>
Comment 6 Adam Barth 2012-09-10 13:21:02 PDT
All reviewed patches have been landed.  Closing bug.