Bug 96279 - Web Inspector: visualize layout root in Timeline
Summary: Web Inspector: visualize layout root in Timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 09:13 PDT by Andrey Kosyakov
Modified: 2012-09-11 07:34 PDT (History)
10 users (show)

See Also:


Attachments
Patch (11.27 KB, patch)
2012-09-10 09:17 PDT, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-09-10 09:13:45 PDT
Show rectangles of the node that was the layout root upon hover over Layout record in Timeline.
Comment 1 Andrey Kosyakov 2012-09-10 09:17:27 PDT
Created attachment 163147 [details]
Patch
Comment 2 Pavel Feldman 2012-09-10 10:07:19 PDT
Comment on attachment 163147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163147&action=review

> Source/WebCore/inspector/TimelineRecordFactory.cpp:211
> +    data->setNumber("x", rect.x());

I've seen methods creating reactsint that class.

> Source/WebCore/inspector/front-end/TimelinePanel.js:950
> +        const recordTypesToHighlight = [

Use object for faster lookup?
Comment 3 Andrey Kosyakov 2012-09-11 07:34:30 PDT
Committed r128184: <http://trac.webkit.org/changeset/128184>