RESOLVED FIXED 96277
Web Inspector: NMI: instrument NativeImageSkia 
https://bugs.webkit.org/show_bug.cgi?id=96277
Summary Web Inspector: NMI: instrument NativeImageSkia
Ilya Tikhonovsky
Reported 2012-09-10 09:08:02 PDT
EOM
Attachments
Patch (6.06 KB, patch)
2012-09-10 09:10 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (4.66 KB, patch)
2012-10-03 07:03 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (5.45 KB, patch)
2012-10-03 07:46 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-09-10 09:10:23 PDT
Created attachment 163144 [details] Patch
Yury Semikhatsky
Comment 2 2012-09-10 21:30:21 PDT
Comment on attachment 163144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163144&action=review > Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:40 > +#include "WebCoreMemoryInstrumentation.h" As discussed, we shouldn't add dependency on WebCore.
Ilya Tikhonovsky
Comment 3 2012-10-03 07:03:22 PDT
Created attachment 166887 [details] Patch
Yury Semikhatsky
Comment 4 2012-10-03 07:25:15 PDT
Comment on attachment 166887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166887&action=review > Source/WebCore/platform/graphics/BitmapImage.cpp:586 > +void reportMemoryUsage(const NativeImageSkia* const&, MemoryObjectInfo*); Let's move this declaration into NativeImagePtr.h next to NativeImagePtr typdef for Skia. > Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:167 > +void reportSkBitmapMemoryUsage(MemoryClassInfo& info, const SkBitmap& image) missing static? > Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:178 > + reportSkBitmapMemoryUsage(info, m_image); Why not declare WTF::reportMemoryUsage(...SkBitmap... and call addMember here?
Ilya Tikhonovsky
Comment 5 2012-10-03 07:46:36 PDT
Created attachment 166891 [details] Patch
Ilya Tikhonovsky
Comment 6 2012-10-03 07:51:07 PDT
Committed r130289: <http://trac.webkit.org/changeset/130289>
Note You need to log in before you can comment on or make changes to this bug.