Bug 96277 - Web Inspector: NMI: instrument NativeImageSkia
Summary: Web Inspector: NMI: instrument NativeImageSkia
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 09:08 PDT by Ilya Tikhonovsky
Modified: 2012-10-03 07:51 PDT (History)
13 users (show)

See Also:

Attachments
Patch (6.06 KB, patch)
2012-09-10 09:10 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (4.66 KB, patch)
2012-10-03 07:03 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2012-10-03 07:46 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-09-10 09:08:02 PDT 
EOM
Comment 1 Ilya Tikhonovsky 2012-09-10 09:10:23 PDT 
Created attachment 163144 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-10 21:30:21 PDT 
Comment on attachment 163144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163144&action=review

> Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:40
> +#include "WebCoreMemoryInstrumentation.h"

As discussed, we shouldn't add dependency on WebCore.
Comment 3 Ilya Tikhonovsky 2012-10-03 07:03:22 PDT 
Created attachment 166887 [details]
Patch
Comment 4 Yury Semikhatsky 2012-10-03 07:25:15 PDT 
Comment on attachment 166887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166887&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:586
> +void reportMemoryUsage(const NativeImageSkia* const&, MemoryObjectInfo*);

Let's move this declaration into NativeImagePtr.h next to NativeImagePtr typdef for Skia.

> Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:167
> +void reportSkBitmapMemoryUsage(MemoryClassInfo& info, const SkBitmap& image)

missing static?

> Source/WebCore/platform/graphics/skia/NativeImageSkia.cpp:178
> +    reportSkBitmapMemoryUsage(info, m_image);

Why not declare WTF::reportMemoryUsage(...SkBitmap... and call addMember here?
Comment 5 Ilya Tikhonovsky 2012-10-03 07:46:36 PDT 
Created attachment 166891 [details]
Patch
Comment 6 Ilya Tikhonovsky 2012-10-03 07:51:07 PDT 
Committed r130289: <http://trac.webkit.org/changeset/130289>