Bug 96273 - [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
Summary: [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on: 96254
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-10 07:39 PDT by Ryuan Choi
Modified: 2012-09-11 21:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (9.80 KB, patch)
2012-09-10 15:37 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2012-09-10 07:39:50 PDT
CodeGeneratorTestRunner.pm needs FEATURE_DEFINES with space separator to know feature macros such as TOUCH_EVENTS.
Comment 1 Ryuan Choi 2012-09-10 15:37:15 PDT
Created attachment 163232 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-09-11 05:50:18 PDT
Comment on attachment 163232 [details]
Patch

Makes sense, thank you.
Comment 3 Gyuyoung Kim 2012-09-11 21:16:50 PDT
Comment on attachment 163232 [details]
Patch

Looks make sense too.
Comment 4 WebKit Review Bot 2012-09-11 21:24:36 PDT
Comment on attachment 163232 [details]
Patch

Clearing flags on attachment: 163232

Committed r128261: <http://trac.webkit.org/changeset/128261>
Comment 5 WebKit Review Bot 2012-09-11 21:24:39 PDT
All reviewed patches have been landed.  Closing bug.