RESOLVED FIXED Bug 96259
[EFL] Create a toggle button for closed captions 
https://bugs.webkit.org/show_bug.cgi?id=96259
Summary [EFL] Create a toggle button for closed captions
Chris Dumez
Reported 2012-09-10 04:43:29 PDT
We need yo add a toggle button for closed captions. Test: media/video-controls-captions.html
Attachments
Patch (130.26 KB, patch)
2012-09-10 05:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-09-10 05:05:15 PDT
Created attachment 163093 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-09-10 05:19:01 PDT
Comment on attachment 163093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163093&action=review > Source/WebCore/platform/efl/RenderThemeEfl.cpp:1303 > + Node* mediaNode = object->node() ? object->node()->shadowHost() : 0; > + if (!mediaNode) > + mediaNode = object->node(); > + if (!mediaNode || (!mediaNode->hasTagName(videoTag))) > + return false; So this is how it is done for other ports?
WebKit Review Bot
Comment 3 2012-09-10 05:56:42 PDT
Comment on attachment 163093 [details] Patch Clearing flags on attachment: 163093 Committed r128049: <http://trac.webkit.org/changeset/128049>
WebKit Review Bot
Comment 4 2012-09-10 05:56:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.