Bug 96259 - [EFL] Create a toggle button for closed captions
Summary: [EFL] Create a toggle button for closed captions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 04:43 PDT by Chris Dumez
Modified: 2012-09-10 05:56 PDT (History)
8 users (show)

See Also:

Attachments
Patch (130.26 KB, patch)
2012-09-10 05:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-10 04:43:29 PDT 
We need yo add a toggle button for closed captions.

Test:
media/video-controls-captions.html
Comment 1 Chris Dumez 2012-09-10 05:05:15 PDT 
Created attachment 163093 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-09-10 05:19:01 PDT 
Comment on attachment 163093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163093&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:1303
> +    Node* mediaNode = object->node() ? object->node()->shadowHost() : 0;
> +    if (!mediaNode)
> +        mediaNode = object->node();
> +    if (!mediaNode || (!mediaNode->hasTagName(videoTag)))
> +        return false;

So this is how it is done for other ports?
Comment 3 WebKit Review Bot 2012-09-10 05:56:42 PDT 
Comment on attachment 163093 [details]
Patch

Clearing flags on attachment: 163093

Committed r128049: <http://trac.webkit.org/changeset/128049>
Comment 4 WebKit Review Bot 2012-09-10 05:56:45 PDT 
All reviewed patches have been landed.  Closing bug.