Bug 96256 – [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Mikhail Pozdnyakov]

WTR needs WebKitTestRunner needs layoutTestController.setMinimumTimerInterval implementation so that 
fast/dom/timer-increase-min-interval-and-reset-part-1.html
fast/dom/timer-increase-min-interval-and-reset-part-2.html
fast/dom/timer-increase-min-interval-repeating.html
fast/dom/timer-increase-min-interval.html
fast/dom/timer-increase-then-decrease-min-interval-repeating.html
fast/dom/timer-increase-then-decrease-min-interval.html
can be unskipped

[Mikhail Pozdnyakov]

Created attachment 163091 [details]
patch

[Chris Dumez]

Comment on attachment 163091 [details]
patch

Looks sane.

[Kenneth Rohde Christiansen]

Comment on attachment 163091 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163091&action=review

> Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:70
> +        void setMinimumTimerInterval(in double interval);

intervalMSecs ? or what is normally used...

[Mikhail Pozdnyakov]

Created attachment 163099 [details]
patch v2

Added a comment to .idl file describing the measure of the given interval parameter for newly added setMinimumTimerInterval().

[Kenneth Rohde Christiansen]

Comment on attachment 163099 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=163099&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:676
> +void TestRunner::setMinimumTimerInterval(double interval)

why not just use "double seconds"

[Mikhail Pozdnyakov]

Created attachment 163106 [details]
patch v3

Used 'seconds' name for the interval parameter in cpp files.

[Kenneth Rohde Christiansen]

Comment on attachment 163106 [details]
patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=163106&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp:234
> +void WKBundleSetMinimumTimerInterval(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, double interval)

seconds

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h:128
> +    void setMinimumTimerInterval(WebPageGroupProxy*, double);

here you have no idea what double means, so it makes sense to add double seconds... I see it is not perfect elsewhere, but this is the right thing to do

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:109
> +    void setMinimumTimerInterval(double); // Interval specified in seconds.

double seconds

[Mikhail Pozdnyakov]

Created attachment 163317 [details]
patch v4

Applied comments from Kenneth.

[WebKit Review Bot]

Comment on attachment 163317 [details]
patch v4

Clearing flags on attachment: 163317

Committed r128169: <http://trac.webkit.org/changeset/128169>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #9)
> (From update of attachment 163317 [details])
> Clearing flags on attachment: 163317
> 
> Committed r128169: <http://trac.webkit.org/changeset/128169>

It caused a regression - https://bugs.webkit.org/show_bug.cgi?id=96396
Could you check it, please?