Bug 96255 – Move InputTypeNames to a separate file

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

We want to move InputTypeNames to a separate file so we can use it without including InputType.h

[Keishi Hattori]

Created attachment 163082 [details]
Patch

[Kent Tamura]

Comment on attachment 163082 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163082&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:25527
> +				C348612415FDE21E007A1CC9 /* InputTypeNames.h in Headers */,

nit: please insert this entry in alphabetical order.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:28621
> +				C348612315FDE21E007A1CC9 /* InputTypeNames.cpp in Sources */,

ditto.

> Source/WebCore/html/InputTypeNames.cpp:9
> + * Copyright (C) 1999 Lars Knoll ([e-mail])
> + *           (C) 1999 Antti Koivisto ([e-mail])
> + *           (C) 2001 Dirk Mueller ([e-mail])
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
> + *           (C) 2006 Alexey Proskuryakov ([e-mail])
> + * Copyright (C) 2007 Samuel Weinig ([e-mail])
> + * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2012 Samsung Electronics. All rights reserved.

The original code was written by me in 2010, an Apple engineer updated some lines in this year, and you add some lines.

* Copyright (C) 2012 Apple Inc. All rights reserved.
* Copyright (C) 2010, 2012 Google Inc. All rights reserved.

is enough.

> Source/WebCore/html/InputTypeNames.h:9
> + * Copyright (C) 1999 Lars Knoll ([e-mail])
> + *           (C) 1999 Antti Koivisto ([e-mail])
> + *           (C) 2001 Dirk Mueller ([e-mail])
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
> + *           (C) 2006 Alexey Proskuryakov ([e-mail])
> + * Copyright (C) 2007 Samuel Weinig ([e-mail])
> + * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
> + * Copyright (C) 2012 Samsung Electronics. All rights reserved.

The original code of InputType.h was written by me in 2010, and you add some.  So,

Copyright (C) 2010, 2012 Google Inc. All rights reserved.

is enough.

[Keishi Hattori]

Created attachment 163264 [details]
Patch

[WebKit Review Bot]

Comment on attachment 163264 [details]
Patch

Clearing flags on attachment: 163264

Committed r128149: <http://trac.webkit.org/changeset/128149>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.