Bug 96252 - Web Inspector: [Elements] Poor performance upon continuous attribute changes
Summary: Web Inspector: [Elements] Poor performance upon continuous attribute changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-10 02:23 PDT by Alexander Pavlov (apavlov)
Modified: 2012-09-10 04:09 PDT (History)
10 users (show)

See Also:

Attachments
Test case (919 bytes, text/html)
2012-09-10 02:26 PDT, Alexander Pavlov (apavlov) 		no flags Details
Patch (6.60 KB, patch)
2012-09-10 02:34 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (7.88 KB, patch)
2012-09-10 03:27 PDT, Alexander Pavlov (apavlov) 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-09-10 02:23:16 PDT 
1. Open the attached test case
2. Select any <div> element.

Observe very slow DOM tree updates and no style data in the Styles sidebar pane.
Comment 1 Alexander Pavlov (apavlov) 2012-09-10 02:26:36 PDT 
Created attachment 163072 [details]
Test case
Comment 2 Alexander Pavlov (apavlov) 2012-09-10 02:34:25 PDT 
Created attachment 163074 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-09-10 02:51:33 PDT 
Comment on attachment 163074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163074&action=review

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:2091
> +        for (var id in this._recentlyModifiedNodes) {

var nodesToUpdate = Object.values(this._recentlyModifiedNodes);
... = nodesToUpdate.length > 10;

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:2117
> +            if (entry.updated) {

entry[WebInspector.ElementsTreeUpdater.ChangeType.Updated]
Comment 4 Alexander Pavlov (apavlov) 2012-09-10 03:27:53 PDT 
Created attachment 163080 [details]
Patch
Comment 5 Alexander Pavlov (apavlov) 2012-09-10 04:09:31 PDT 
Committed r128043: <http://trac.webkit.org/changeset/128043>