WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 96231
Refactored op_tear_off* to support activations that don't allocate space for 'arguments'
https://bugs.webkit.org/show_bug.cgi?id=96231
Summary
Refactored op_tear_off* to support activations that don't allocate space for ...
Geoffrey Garen
Reported
2012-09-09 22:57:14 PDT
Refactored op_tear_off* to support activations that don't allocate space for 'arguments'
Attachments
Patch
(36.96 KB, patch)
2012-09-09 23:22 PDT
,
Geoffrey Garen
barraclough
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2012-09-09 23:22:09 PDT
Created
attachment 163044
[details]
Patch
Gavin Barraclough
Comment 2
2012-09-10 01:14:04 PDT
Comment on
attachment 163044
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=163044&action=review
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1116 > + // We can't hash JSValue(), so just return a non-uniqued value.
We could cache this separately from the hashtable (remember the first added in a separate var).
Geoffrey Garen
Comment 3
2012-09-10 13:23:17 PDT
Committed
r128096
: <
http://trac.webkit.org/changeset/128096
>
Geoffrey Garen
Comment 4
2012-09-10 16:13:50 PDT
Windows (32-bit) fix: <
http://trac.webkit.org/changeset/128122
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug