Bug 96231 - Refactored op_tear_off* to support activations that don't allocate space for 'arguments'
Summary: Refactored op_tear_off* to support activations that don't allocate space for ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-09 22:57 PDT by Geoffrey Garen
Modified: 2012-09-10 16:13 PDT (History)
0 users

See Also:

Attachments
Patch (36.96 KB, patch)
2012-09-09 23:22 PDT, Geoffrey Garen 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-09-09 22:57:14 PDT 
Refactored op_tear_off* to support activations that don't allocate space for 'arguments'
Comment 1 Geoffrey Garen 2012-09-09 23:22:09 PDT 
Created attachment 163044 [details]
Patch
Comment 2 Gavin Barraclough 2012-09-10 01:14:04 PDT 
Comment on attachment 163044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163044&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1116
> +    // We can't hash JSValue(), so just return a non-uniqued value.

We could cache this separately from the hashtable (remember the first added in a separate var).
Comment 3 Geoffrey Garen 2012-09-10 13:23:17 PDT 
Committed r128096: <http://trac.webkit.org/changeset/128096>
Comment 4 Geoffrey Garen 2012-09-10 16:13:50 PDT 
Windows (32-bit) fix: <http://trac.webkit.org/changeset/128122>.