Bug 96228 - Simplify WebKit2 XPC service backend now that I know it doesn't need to soft link WebKit2.framework
Summary: Simplify WebKit2 XPC service backend now that I know it doesn't need to soft ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-09 22:41 PDT by Sam Weinig
Modified: 2012-09-10 00:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch (27.32 KB, patch)
2012-09-09 22:55 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (26.93 KB, patch)
2012-09-09 23:03 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-09-09 22:41:36 PDT
Simplify WebKit2 XPC service backend now that I know it doesn't need to soft link WebKit2.framework
Comment 1 Sam Weinig 2012-09-09 22:55:33 PDT
Created attachment 163042 [details]
Patch
Comment 2 Sam Weinig 2012-09-09 23:03:35 PDT
Created attachment 163043 [details]
Patch
Comment 3 mitz 2012-09-09 23:13:25 PDT
Comment on attachment 163043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163043&action=review

> Source/WebKit2/WebProcess/mac/WebProcessXPCServiceMain.mm:52
> +            assert(type == XPC_TYPE_DICTIONARY);

Now that this is in the framework, I think you can use ASSERT.
Comment 4 Sam Weinig 2012-09-10 00:04:57 PDT
Committed r128021: <http://trac.webkit.org/changeset/128021>