Bug 96219 - AX: Update Windows port accessible role mappings to fix some tests
Summary: AX: Update Windows port accessible role mappings to fix some tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-09 14:58 PDT by Dominic Mazzoni
Modified: 2012-09-10 14:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2012-09-09 15:04 PDT, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2012-09-09 19:02 PDT, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2012-09-09 14:58:41 PDT 
Tests currently failing due to https://bugs.webkit.org/show_bug.cgi?id=94870:

accessibility/adjacent-continuations-cause-assertion-failure.html
accessibility/deleting-iframe-destroys-axcache.html
accessibility/div-within-anchors-causes-crash.html
Comment 1 Dominic Mazzoni 2012-09-09 15:00:58 PDT 
I'm uploading a patch that should fix the tests. While I was at it, I tried to map a few more accessible roles on Windows - the ones that I'm reasonably confident about based on the Chromium source code.

Roger, could you patch this in and see if it fixes these three tests and doesn't break anything else on Windows?
Comment 2 Dominic Mazzoni 2012-09-09 15:04:30 PDT 
Created attachment 163015 [details]
Patch
Comment 3 Build Bot 2012-09-09 15:28:48 PDT 
Comment on attachment 163015 [details]
Patch

Attachment 163015 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13805300
Comment 4 Dominic Mazzoni 2012-09-09 19:02:06 PDT 
Created attachment 163024 [details]
Patch
Comment 5 WebKit Review Bot 2012-09-10 09:16:39 PDT 
Comment on attachment 163024 [details]
Patch

Clearing flags on attachment: 163024

Committed r128066: <http://trac.webkit.org/changeset/128066>
Comment 6 WebKit Review Bot 2012-09-10 09:16:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Roger Fong 2012-09-10 14:37:07 PDT 
Hello, sorry I didn't check this earlier. But the patch has landed, the tests aren't failing and everything still builds, so I guess it's good :)