Bug 96218 - CRITICAL **: void webkit_download_start(WebKitDownload*): assertion `priv->timer == NULL' failed
Summary: CRITICAL **: void webkit_download_start(WebKitDownload*): assertion `priv->ti...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-09 14:40 PDT by Paul Menzel
Modified: 2014-04-08 19:03 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Menzel 2012-09-09 14:40:19 PDT
With either Debian or Fedora 17 using Midori (0.4.6) with libwebkitgtk (1.8.1-3.1) downloading a file (for example PDF) the following message is printed to the console.

    ** (midori4:4274): CRITICAL **: void webkit_download_start(WebKitDownload*): assertion `priv->timer == NULL' failed

It does not matter if the file is opened or saved, the warning does always appear.

Looking at `webkitdownload.cpp` [1] I do not see when

    static void webkit_download_init(WebKitDownload* download) {}

is called and grepping through the source it looks like it never is.


[1] http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp#L506
Comment 1 Alberto Garcia 2013-09-09 05:11:15 PDT
(In reply to comment #0)
>     ** (midori4:4274): CRITICAL **: void webkit_download_start(WebKitDownload*): assertion `priv->timer == NULL' failed

Looks like webkit_download_start() is being called twice, maybe it's a
bug in Midori?

> Looking at `webkitdownload.cpp` [1] I do not see when
>
>     static void webkit_download_init(WebKitDownload* download) {}
>
> is called and grepping through the source it looks like it never is.

That function is called when the WebKitDownload object is created.

The code that calls that function is generated from the G_DEFINE_TYPE
macro in that file.
Comment 2 Martin Robinson 2014-04-08 19:03:56 PDT
The GTK+ port of WebKit1 has been removed.