[chromium] webkit_platform should only be linked into the webkit target
Created attachment 163008 [details] Patch
Motivation here is to be able to statically link in some of these targets without accidentally pulling in copies of WEBKIT_EXPORT'd symbols outside of webkit.dll
Comment on attachment 163008 [details] Patch R=me.
Comment on attachment 163008 [details] Patch Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target?
(In reply to comment #3) > (From update of attachment 163008 [details]) > Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target? Yeah, it's unfortunate. I think having both webkit_wtf_support and webcore_prerequisites export the include_dirs as a dependent setting is about as good as you can get. And yeah, we do already add Platform.gyp:webkit_platform to the webkit target.
(In reply to comment #3) > (From update of attachment 163008 [details]) > Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target? Yes: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/WebKit.gyp#L74
ok
Comment on attachment 163008 [details] Patch Clearing flags on attachment: 163008 Committed r127995: <http://trac.webkit.org/changeset/127995>
All reviewed patches have been landed. Closing bug.