Bug 96213 - [chromium] webkit_platform should only be linked into the webkit target
Summary: [chromium] webkit_platform should only be linked into the webkit target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-09 12:52 PDT by James Robinson
Modified: 2012-09-09 14:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.62 KB, patch)
2012-09-09 12:53 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-09-09 12:52:41 PDT
[chromium] webkit_platform should only be linked into the webkit target
Comment 1 James Robinson 2012-09-09 12:53:44 PDT
Created attachment 163008 [details]
Patch
Comment 2 James Robinson 2012-09-09 12:54:45 PDT
Motivation here is to be able to statically link in some of these targets without accidentally pulling in copies of WEBKIT_EXPORT'd symbols outside of webkit.dll
Comment 3 Adrienne Walker 2012-09-09 13:17:58 PDT
Comment on attachment 163008 [details]
Patch

R=me.
Comment 4 Adam Barth 2012-09-09 13:17:58 PDT
Comment on attachment 163008 [details]
Patch

Ok.  It's lame that we have to add these include_dirs explicitly.  I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target?
Comment 5 Adrienne Walker 2012-09-09 13:24:01 PDT
(In reply to comment #3)
> (From update of attachment 163008 [details])
> Ok.  It's lame that we have to add these include_dirs explicitly.  I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target?

Yeah, it's unfortunate.  I think having both webkit_wtf_support and webcore_prerequisites export the include_dirs as a dependent setting is about as good as you can get.

And yeah, we do already add Platform.gyp:webkit_platform to the webkit target.
Comment 6 James Robinson 2012-09-09 13:25:01 PDT
(In reply to comment #3)
> (From update of attachment 163008 [details])
> Ok.  It's lame that we have to add these include_dirs explicitly.  I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target?

Yes: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/WebKit.gyp#L74
Comment 7 Adam Barth 2012-09-09 13:31:56 PDT
ok
Comment 8 James Robinson 2012-09-09 14:04:19 PDT
Comment on attachment 163008 [details]
Patch

Clearing flags on attachment: 163008

Committed r127995: <http://trac.webkit.org/changeset/127995>
Comment 9 James Robinson 2012-09-09 14:04:23 PDT
All reviewed patches have been landed.  Closing bug.