RESOLVED FIXED Bug 96213
[chromium] webkit_platform should only be linked into the webkit target 
https://bugs.webkit.org/show_bug.cgi?id=96213
Summary [chromium] webkit_platform should only be linked into the webkit target
James Robinson
Reported 2012-09-09 12:52:41 PDT
[chromium] webkit_platform should only be linked into the webkit target
Attachments
Patch (4.62 KB, patch)
2012-09-09 12:53 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-09-09 12:53:44 PDT
Created attachment 163008 [details] Patch
James Robinson
Comment 2 2012-09-09 12:54:45 PDT
Motivation here is to be able to statically link in some of these targets without accidentally pulling in copies of WEBKIT_EXPORT'd symbols outside of webkit.dll
Adrienne Walker
Comment 3 2012-09-09 13:17:58 PDT
Comment on attachment 163008 [details] Patch R=me.
Adam Barth
Comment 4 2012-09-09 13:17:58 PDT
Comment on attachment 163008 [details] Patch Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target?
Adrienne Walker
Comment 5 2012-09-09 13:24:01 PDT
(In reply to comment #3) > (From update of attachment 163008 [details]) > Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target? Yeah, it's unfortunate. I think having both webkit_wtf_support and webcore_prerequisites export the include_dirs as a dependent setting is about as good as you can get. And yeah, we do already add Platform.gyp:webkit_platform to the webkit target.
James Robinson
Comment 6 2012-09-09 13:25:01 PDT
(In reply to comment #3) > (From update of attachment 163008 [details]) > Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target? Yes: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/WebKit.gyp#L74
Adam Barth
Comment 7 2012-09-09 13:31:56 PDT
ok
James Robinson
Comment 8 2012-09-09 14:04:19 PDT
Comment on attachment 163008 [details] Patch Clearing flags on attachment: 163008 Committed r127995: <http://trac.webkit.org/changeset/127995>
James Robinson
Comment 9 2012-09-09 14:04:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.