Bug 96208 - [EFL][WK2] Gardening to make the bot green
Summary: [EFL][WK2] Gardening to make the bot green
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 96205
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-09 09:17 PDT by Chris Dumez
Modified: 2012-09-09 09:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.31 KB, patch)
2012-09-09 09:24 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-09 09:17:45 PDT
We currently have a few failures on the WK2 EFL making it red.
Comment 1 Chris Dumez 2012-09-09 09:24:22 PDT
Created attachment 162998 [details]
Patch

Could someone please cq+?
Comment 2 Chris Dumez 2012-09-09 09:26:29 PDT
Style error is expected. It is caused by Bug 96205.
Comment 3 WebKit Review Bot 2012-09-09 09:26:48 PDT
Attachment 162998 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/efl-wk2/TestExpectations:1:  No port uses path LayoutTests/platform/efl-wk2/TestExpectations for test_expectations  [test/expectations] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-09-09 09:44:45 PDT
Comment on attachment 162998 [details]
Patch

Clearing flags on attachment: 162998

Committed r127985: <http://trac.webkit.org/changeset/127985>
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-09-09 09:44:53 PDT
All reviewed patches have been landed.  Closing bug.