Bug 96194 - Switch to entering the sandbox directly from main(), rather than waiting for the initialization message
Summary: Switch to entering the sandbox directly from main(), rather than waiting for ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
Depends on:
Reported: 2012-09-08 23:52 PDT by Sam Weinig
Modified: 2013-01-14 16:42 PST (History)
1 user (show)

See Also:

Patch (12.60 KB, patch)
2012-09-09 11:07 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Update patch (12.82 KB, patch)
2012-09-09 12:46 PDT, Sam Weinig
mitz: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2012-09-08 23:52:05 PDT
Switch to entering the sandbox directly from main(), rather than waiting for the intialization message
Comment 1 Sam Weinig 2012-09-09 11:07:41 PDT
Created attachment 163003 [details]
Comment 2 mitz 2012-09-09 11:55:40 PDT
Comment on attachment 163003 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=163003&action=review

> Source/WebKit2/ChangeLog:10
> +        Pass a client identifier to WebProcess as an command line argument

Typo: an

> Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:101
> +    // Initialize the sandbox.

Useless comment.

> Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:145
> +        ASSERT(clientIdentifier);

We can’t make assertions about what’s passed on the command line, since that’s outside of WebKit’s control. You should replace this with error logging and, presumably, exiting with an error code.

> Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:235
> +    // Initialize the shim.

Useless comment.

> Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:238
> +    // Initialize the sandbox.

Useless comment.

> Source/WebKit2/WebProcess/mac/WebProcessMainMac.mm:244
> +    // Register with AX as a remote app.

Extremely useless comment.
Comment 3 Sam Weinig 2012-09-09 12:46:28 PDT
Created attachment 163006 [details]
Update patch
Comment 4 Build Bot 2012-09-09 12:53:40 PDT
Comment on attachment 163006 [details]
Update patch

Attachment 163006 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13798547
Comment 5 Sam Weinig 2012-09-09 15:47:28 PDT
Committed r128003: <http://trac.webkit.org/changeset/128003>
Comment 6 Alexey Proskuryakov 2013-01-14 16:42:38 PST
Sandboxing follow-up in bug 106840.