Bug 96190 - Pass full target idl file path to CodeGenerator as a constructor argument.
Summary: Pass full target idl file path to CodeGenerator as a constructor argument.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks: 96181
  Show dependency treegraph
 
Reported: 2012-09-08 22:54 PDT by Kangil Han
Modified: 2012-09-09 19:08 PDT (History)
4 users (show)

See Also:


Attachments
patch (2.77 KB, patch)
2012-09-09 00:31 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-09-08 22:54:18 PDT
It seems passing idl file path to CodeGenerator would be useful because CodeGenerator* family could manipulate it when creating derived header and cpp files.
Comment 1 Kangil Han 2012-09-09 00:31:59 PDT
Created attachment 162983 [details]
patch
Comment 2 Kentaro Hara 2012-09-09 00:35:20 PDT
Comment on attachment 162983 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162983&action=review

> Source/WebCore/ChangeLog:8
> +        Passing idl file path to CodeGenerator would be useful because CodeGenerator* family could manipulate it when creating derived header and cpp files.

What use case are you assuming?
Comment 3 Kangil Han 2012-09-09 00:41:04 PDT
(In reply to comment #2)
> 
> What use case are you assuming?

At this stage, One use case that fills out derived sources with original copyrights.
Please refer to BUG 96181. :-)
Comment 4 Kentaro Hara 2012-09-09 00:44:29 PDT
Comment on attachment 162983 [details]
patch

OK
Comment 5 Kangil Han 2012-09-09 00:45:40 PDT
(In reply to comment #4)
> (From update of attachment 162983 [details])
> OK

Thx!!
Comment 6 WebKit Review Bot 2012-09-09 19:08:11 PDT
Comment on attachment 162983 [details]
patch

Clearing flags on attachment: 162983

Committed r128010: <http://trac.webkit.org/changeset/128010>
Comment 7 WebKit Review Bot 2012-09-09 19:08:14 PDT
All reviewed patches have been landed.  Closing bug.