Bug 96183 - [chromium] Add GestureTapCancel WebGestureEvent type
Summary: [chromium] Add GestureTapCancel WebGestureEvent type
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Rick Byers
Depends on:
Blocks: 96060
  Show dependency treegraph
Reported: 2012-09-08 08:01 PDT by Rick Byers
Modified: 2012-09-10 13:09 PDT (History)
8 users (show)

See Also:

Patch (4.13 KB, patch)
2012-09-08 11:13 PDT, Rick Byers
no flags Details | Formatted Diff | Diff
Patch (6.54 KB, patch)
2012-09-08 13:37 PDT, Rick Byers
no flags Details | Formatted Diff | Diff
Patch (5.79 KB, patch)
2012-09-08 19:03 PDT, Rick Byers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Byers 2012-09-08 08:01:23 PDT
The first step for bug 96060 is to add a new unused gesture type to the chromium layer.  For now we just ignore any such gestures, so that we can update chromium to send them without breaking anything.  Then we can update WebCore to rely on them.
Comment 1 Rick Byers 2012-09-08 11:13:08 PDT
Created attachment 162962 [details]
Comment 2 WebKit Review Bot 2012-09-08 11:16:06 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 WebKit Review Bot 2012-09-08 11:20:23 PDT
Comment on attachment 162962 [details]

Attachment 162962 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13789590
Comment 4 Rick Byers 2012-09-08 13:37:29 PDT
Created attachment 162966 [details]
Comment 5 Rick Byers 2012-09-08 19:03:37 PDT
Created attachment 162973 [details]
Comment 6 Adam Barth 2012-09-10 12:51:44 PDT
Comment on attachment 162973 [details]

Comment 7 WebKit Review Bot 2012-09-10 13:09:24 PDT
Comment on attachment 162973 [details]

Clearing flags on attachment: 162973

Committed r128093: <http://trac.webkit.org/changeset/128093>
Comment 8 WebKit Review Bot 2012-09-10 13:09:27 PDT
All reviewed patches have been landed.  Closing bug.