Bug 96172 - Remove String::operator+=()
Summary: Remove String::operator+=()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 97412
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-07 20:13 PDT by Patrick R. Gansterer
Modified: 2012-09-24 17:28 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2012-09-07 20:16 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (3.32 KB, patch)
2012-09-22 00:10 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2012-09-24 08:46 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-09-07 20:13:30 PDT 
Remove String::operator+=()
Comment 1 Patrick R. Gansterer 2012-09-07 20:16:19 PDT 
Created attachment 162936 [details]
Patch
Comment 2 Benjamin Poulain 2012-09-07 20:54:54 PDT 
Comment on attachment 162936 [details]
Patch

Looks like the GTK bot is not happy.
Comment 3 Patrick R. Gansterer 2012-09-22 00:10:20 PDT 
Created attachment 165252 [details]
Patch
Comment 4 Benjamin Poulain 2012-09-22 00:37:08 PDT 
Comment on attachment 165252 [details]
Patch

r=me. Wait for the ews to cq+.
Comment 5 WebKit Review Bot 2012-09-22 00:51:24 PDT 
Comment on attachment 165252 [details]
Patch

Attachment 165252 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13956943
Comment 6 Peter Beverloo (cr-android ews) 2012-09-22 01:10:33 PDT 
Comment on attachment 165252 [details]
Patch

Attachment 165252 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13950953
Comment 7 Patrick R. Gansterer 2012-09-24 08:46:57 PDT 
Created attachment 165391 [details]
Patch
Comment 8 WebKit Review Bot 2012-09-24 17:28:32 PDT 
Comment on attachment 165391 [details]
Patch

Clearing flags on attachment: 165391

Committed r129433: <http://trac.webkit.org/changeset/129433>
Comment 9 WebKit Review Bot 2012-09-24 17:28:35 PDT 
All reviewed patches have been landed.  Closing bug.