Bug 96165 - WebKit Git fails to build with --with-acceleration-backend=clutter
Summary: WebKit Git fails to build with --with-acceleration-backend=clutter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 17:11 PDT by Siraj razick
Modified: 2012-09-12 15:35 PDT (History)
3 users (show)

See Also:

Attachments
Build fix for webkit clutter AC backend (9.41 KB, patch)
2012-09-12 13:15 PDT, Siraj razick 		no flags Details | Formatted Diff | Diff
Error Log (2.14 KB, text/plain)
2012-09-12 13:51 PDT, Siraj razick 		no flags Details
Updated patch with USE(GLX) (9.52 KB, patch)
2012-09-12 14:48 PDT, Siraj razick 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Siraj razick 2012-09-07 17:11:48 PDT 
Due to the Changes merged from  https://bugs.webkit.org/show_bug.cgi?id=90085 --with-acceleration-backend=clutter doesn't
build anymore
Comment 1 Siraj razick 2012-09-12 13:15:09 PDT 
Created attachment 163679 [details]
Build fix for webkit clutter AC backend
Comment 2 Martin Robinson 2012-09-12 13:29:42 PDT 
Comment on attachment 163679 [details]
Build fix for webkit clutter AC backend

View in context: https://bugs.webkit.org/attachment.cgi?id=163679&action=review

> Source/WebCore/GNUmakefile.list.am:5954
> +if USE_TEXTURE_MAPPER_GL
> +webcoregtk_sources += \
> +	Source/WebCore/platform/gtk/RedirectedXCompositeWindow.cpp \
> +	Source/WebCore/platform/gtk/RedirectedXCompositeWindow.h
> +endif

What's the compiler message when you try to compile these with the Clutter backend?
Comment 3 Siraj razick 2012-09-12 13:51:01 PDT 
Created attachment 163684 [details]
Error Log

Error Log when RedirectedXCompositeWindow gets compiled with clutter backend
Comment 4 Martin Robinson 2012-09-12 14:15:13 PDT 
(In reply to comment #3)
> Created an attachment (id=163684) [details]
> Error Log
> 
> Error Log when RedirectedXCompositeWindow gets compiled with clutter backend

It seems that RedirectedXCompositeWindow.cpp/h needs to be protected by USE(GLX) just like Source/WebCore/platform/graphics/glx/GLContextGLX.cpp/h. I think that's a better approach than conditional inclusion on the sources list.
Comment 5 Siraj razick 2012-09-12 14:48:26 PDT 
Created attachment 163703 [details]
Updated patch with USE(GLX)

ok :), I removed the conditional inclusion from the source list and added USE(GLX) to protect the file
Comment 6 Martin Robinson 2012-09-12 14:52:09 PDT 
Comment on attachment 163703 [details]
Updated patch with USE(GLX)

Thank you!
Comment 7 WebKit Review Bot 2012-09-12 15:35:46 PDT 
Comment on attachment 163703 [details]
Updated patch with USE(GLX)

Clearing flags on attachment: 163703

Committed r128372: <http://trac.webkit.org/changeset/128372>
Comment 8 WebKit Review Bot 2012-09-12 15:35:49 PDT 
All reviewed patches have been landed.  Closing bug.