Bug 96124 - AX: Chromium needs access to canvasHasFallbackContent
Summary: AX: Chromium needs access to canvasHasFallbackContent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 10:03 PDT by Dominic Mazzoni
Modified: 2012-09-07 15:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.61 KB, patch)
2012-09-07 10:39 PDT, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2012-09-07 10:03:00 PDT 
In WebAccessibilityObject
Comment 1 Dominic Mazzoni 2012-09-07 10:39:58 PDT 
Created attachment 162811 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-07 10:43:40 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 chris fleizach 2012-09-07 13:57:36 PDT 
Comment on attachment 162811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162811&action=review

> Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:243
> +        roleString += "WithFallbackContent";

it's a little weird to modify the role string like this
i might have chosen to make it "AXCanvas (With Fallback Content)" 
but that's a minor nit
Comment 4 WebKit Review Bot 2012-09-07 15:54:59 PDT 
Comment on attachment 162811 [details]
Patch

Clearing flags on attachment: 162811

Committed r127931: <http://trac.webkit.org/changeset/127931>
Comment 5 WebKit Review Bot 2012-09-07 15:55:03 PDT 
All reviewed patches have been landed.  Closing bug.