Bug 96119 - Web Inspector: only display heap size statistics for timeline records when it makes sense
Summary: Web Inspector: only display heap size statistics for timeline records when it...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
Depends on:
Reported: 2012-09-07 09:50 PDT by Andrey Kosyakov
Modified: 2012-09-10 07:02 PDT (History)
10 users (show)

See Also:

Patch (36.85 KB, patch)
2012-09-07 10:22 PDT, Andrey Kosyakov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-09-07 09:50:23 PDT
We used to display heap size statistics for all records. This does not seem to make much sense. Also, total heap size does not seem to be very meaningful.
Let's drop totalHeapSize and instead add usedHeapSizeDelta, as the delta between the start and stop of the event.
Comment 1 Andrey Kosyakov 2012-09-07 10:22:38 PDT
Created attachment 162803 [details]
Comment 2 Yury Semikhatsky 2012-09-10 05:43:28 PDT
Comment on attachment 162803 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=162803&action=review

> Source/WebCore/English.lproj/localizedStrings.js:741
> +localizedStrings["%s (delta %s)"] = "%s (delta %s)";

I'd rather show (+xx) or (-xx) without 'delta'.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:808
> +        if ((this.usedHeapSize && this.category === WebInspector.TimelinePresentationModel.categories().scripting) || this.usedHeapSizeDelta) {

Should be: this.usedHeapSize && (this.category === WebInspector.TimelinePresentationModel.categories().scripting || this.usedHeapSizeDelta)
Comment 3 Andrey Kosyakov 2012-09-10 07:02:30 PDT
Committed r128057: <http://trac.webkit.org/changeset/128057>