RESOLVED FIXED Bug 96119
Web Inspector: only display heap size statistics for timeline records when it makes sense 
https://bugs.webkit.org/show_bug.cgi?id=96119
Summary Web Inspector: only display heap size statistics for timeline records when it...
Andrey Kosyakov
Reported 2012-09-07 09:50:23 PDT
We used to display heap size statistics for all records. This does not seem to make much sense. Also, total heap size does not seem to be very meaningful. Let's drop totalHeapSize and instead add usedHeapSizeDelta, as the delta between the start and stop of the event.
Attachments
Patch (36.85 KB, patch)
2012-09-07 10:22 PDT, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-09-07 10:22:38 PDT
Created attachment 162803 [details] Patch
Yury Semikhatsky
Comment 2 2012-09-10 05:43:28 PDT
Comment on attachment 162803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162803&action=review > Source/WebCore/English.lproj/localizedStrings.js:741 > +localizedStrings["%s (delta %s)"] = "%s (delta %s)"; I'd rather show (+xx) or (-xx) without 'delta'. > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:808 > + if ((this.usedHeapSize && this.category === WebInspector.TimelinePresentationModel.categories().scripting) || this.usedHeapSizeDelta) { Should be: this.usedHeapSize && (this.category === WebInspector.TimelinePresentationModel.categories().scripting || this.usedHeapSizeDelta)
Andrey Kosyakov
Comment 3 2012-09-10 07:02:30 PDT
Committed r128057: <http://trac.webkit.org/changeset/128057>
Note You need to log in before you can comment on or make changes to this bug.