Bug 96107 – [Gtk] Enable Resource Timing

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKitGTK

[José Dapena Paz]

Add settings for enabling performance timeline and resource timing support in WebKit GTK+. It will be disabled by default, waiting for a sufficiently mature implementation.

[José Dapena Paz]

Created attachment 162770 [details]
Patch

Patch adding settings for enabling resource timing and performance timeline

[Martin Robinson]

Comment on attachment 162770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162770&action=review

> configure.ac:981
> +# check whether to enable Performance Timeline support
> +AC_MSG_CHECKING([whether to enable Performance Timeline support])
> +AC_ARG_ENABLE(performance_timeline,
> +              AC_HELP_STRING([--enable-performance-timeline],
> +                             [enable support for Performance Timeline (experimental) [default=no]]),
> +              [],[enable_performance_timeline=$enable_unstable_features])
> +AC_MSG_RESULT([$enable_performance_timeline])

I don't think we add configuration options for features that aren't complete yet. Zan has the details.

[Zan Dobersek]

Comment on attachment 162770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162770&action=review

>> configure.ac:981
>> +AC_MSG_RESULT([$enable_performance_timeline])
> 
> I don't think we add configuration options for features that aren't complete yet. Zan has the details.

Correct. Both these features don't introduce any dependencies so the configuration flags aren't required.

Besides all the changes in configure.ac, this also removes the need for checking the Automake conditionals in Source/WebCore/GNUmakefile.am.

[Philippe Normand]

Comment on attachment 162770 [details]
Patch

This one got bitrot :( At least the autotools part. Would need to be rebased so EWS can process it.

[Blaze Burg]

*** This bug has been marked as a duplicate of bug 30685 ***