Bug 96103 – Web Inspector: show time frame were blocked by flushing of previous frames in Timeline

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

One of common causes for frame start being delayed is that the previous frame is still being flushed to the screen. Currently, this is indistinguishable from idle time on timeline. Let's add instrumentation to points where we delay frame start because of pending update and show time that frame is blocked by previous frame.

[Andrey Kosyakov]

Created attachment 162771 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Pavel Feldman]

Comment on attachment 162771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162771&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:217
> +    if (m_hadDelayFrameRecord)

Why is it safe to drop subsequent delays?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:573
> +        presentationModel._delayFrameRecord = null;

This makes code much more complex. Why exactly do we need this?

[Brian Burg]

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.