RESOLVED FIXED 96101
Web Inspector: NMI: move WebCore specific code to separate header 
https://bugs.webkit.org/show_bug.cgi?id=96101
Summary Web Inspector: NMI: move WebCore specific code to separate header
Ilya Tikhonovsky
Reported 2012-09-07 06:31:39 PDT
I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h
Attachments
Patch (89.87 KB, patch)
2012-09-07 06:36 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
for mac bot (92.86 KB, patch)
2012-09-07 07:04 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
for mac bot (92.90 KB, patch)
2012-09-07 07:32 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-09-07 06:36:09 PDT
Created attachment 162755 [details] Patch
Build Bot
Comment 2 2012-09-07 07:00:17 PDT
Comment on attachment 162755 [details] Patch Attachment 162755 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13776696
Ilya Tikhonovsky
Comment 3 2012-09-07 07:04:10 PDT
Created attachment 162761 [details] for mac bot
Ilya Tikhonovsky
Comment 4 2012-09-07 07:32:34 PDT
Created attachment 162767 [details] for mac bot
Yury Semikhatsky
Comment 5 2012-09-07 08:24:45 PDT
Comment on attachment 162767 [details] for mac bot View in context: https://bugs.webkit.org/attachment.cgi?id=162767&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:55306 > + RelativePath="..\dom\WebCoreMemoryInstrumentation.cpp" I believe WebCore/inspector would be a better place for these files. > Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:34 > #include "MemoryInstrumentationImpl.h" No need in this include anymore.
Ilya Tikhonovsky
Comment 6 2012-09-07 08:28:53 PDT
> > Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:34 > > #include "MemoryInstrumentationImpl.h" > > No need in this include anymore. Test uses MemoryInstrymentationImpl directly.
Ilya Tikhonovsky
Comment 7 2012-09-07 08:36:25 PDT
Comment on attachment 162767 [details] for mac bot Clearing flags on attachment: 162767 Committed r127869: <http://trac.webkit.org/changeset/127869>
Ilya Tikhonovsky
Comment 8 2012-09-07 08:36:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.