Bug 96090 - [EFL][WK2] Unskip test cases that are now passing consistently
Summary: [EFL][WK2] Unskip test cases that are now passing consistently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-07 03:13 PDT by Chris Dumez
Modified: 2012-09-07 09:31 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.00 KB, patch)
2012-09-07 03:14 PDT, Chris Dumez
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (2.91 KB, patch)
2012-09-07 06:54 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-07 03:13:07 PDT
Several test cases are passing consistently on the EFL WK2 debuild bot but expected to fail.
We need to remove them from TestExpectations.
Comment 1 Chris Dumez 2012-09-07 03:14:42 PDT
Created attachment 162727 [details]
Patch

Could someone please cq+ ?
Comment 2 WebKit Review Bot 2012-09-07 04:13:10 PDT
Comment on attachment 162727 [details]
Patch

Rejecting attachment 162727 [details] from commit-queue.

New failing tests:
inspector/styles/protocol-css-regions-commands.html
Full output: http://queues.webkit.org/results/13771741
Comment 3 Chris Dumez 2012-09-07 04:17:16 PDT
Comment on attachment 162727 [details]
Patch

False alarm. Could someone please cq+ again?
Comment 4 WebKit Review Bot 2012-09-07 06:48:06 PDT
Comment on attachment 162727 [details]
Patch

Rejecting attachment 162727 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/efl-wk2/TestExpectations
Hunk #2 FAILED at 226.
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/efl-wk2/TestExpectations.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/13770769
Comment 5 Chris Dumez 2012-09-07 06:54:25 PDT
Created attachment 162757 [details]
Patch

Rebased on master. Could someone please cq+ ?
Comment 6 WebKit Review Bot 2012-09-07 09:31:07 PDT
Comment on attachment 162757 [details]
Patch

Clearing flags on attachment: 162757

Committed r127878: <http://trac.webkit.org/changeset/127878>
Comment 7 WebKit Review Bot 2012-09-07 09:31:11 PDT
All reviewed patches have been landed.  Closing bug.