Bug 96082 – Fix FilterTypeZoom to properly call canvas->restore()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zachary Kuznia]

Fix FilterTypeZoom to properly call canvas->restore()

[Zachary Kuznia]

Created attachment 162703 [details]
Patch

[Adrienne Walker]

Comment on attachment 162703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443
> -            canvas->drawBitmap(state.source(), 0, 0);
> +            canvas->drawSprite(state.source(), 0, 0, &paint);

Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here.

[Zachary Kuznia]

Created attachment 163040 [details]
Patch

[Zachary Kuznia]

(In reply to comment #2)
> (From update of attachment 162703 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review
> 
> > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443
> > -            canvas->drawBitmap(state.source(), 0, 0);
> > +            canvas->drawSprite(state.source(), 0, 0, &paint);
> 
> Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here.

Upon further investigation, it seems that "canvas->Restore()" was sufficient, so I reverted this call.

[Adrienne Walker]

Comment on attachment 163040 [details]
Patch

R=me.

[WebKit Review Bot]

Comment on attachment 163040 [details]
Patch

Clearing flags on attachment: 163040

Committed r128196: <http://trac.webkit.org/changeset/128196>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.