Fix FilterTypeZoom to properly call canvas->restore()
Created attachment 162703 [details] Patch
Comment on attachment 162703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443 > - canvas->drawBitmap(state.source(), 0, 0); > + canvas->drawSprite(state.source(), 0, 0, &paint); Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here.
Created attachment 163040 [details] Patch
(In reply to comment #2) > (From update of attachment 162703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443 > > - canvas->drawBitmap(state.source(), 0, 0); > > + canvas->drawSprite(state.source(), 0, 0, &paint); > > Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here. Upon further investigation, it seems that "canvas->Restore()" was sufficient, so I reverted this call.
Comment on attachment 163040 [details] Patch R=me.
Comment on attachment 163040 [details] Patch Clearing flags on attachment: 163040 Committed r128196: <http://trac.webkit.org/changeset/128196>
All reviewed patches have been landed. Closing bug.