Bug 96078 - [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build
Summary: [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2012-09-07 00:41 PDT by Zoltan Arvai
Modified: 2012-09-07 03:44 PDT (History)
5 users (show)

See Also:


Attachments
patch (1.38 KB, patch)
2012-09-07 00:45 PDT, Zoltan Arvai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2012-09-07 00:41:19 PDT
Currently QtWebKit MSVC build on Windows places JSC, DumpRenderTree, ImageDiff and QtTestBrowser to wrong directories:
WebKitBuild\Release\Source\bin\jsc.exe
WebKitBuild\Release\Tools\DumpRenderTree\bin\DumpRenderTree.exe
WebKitBuild\Release\Tools\DumpRenderTree\bin\ImageDiff.exe
WebKitBuild\Release\Tools\bin\QtTestBrowser.exe

Those should land in WebKitBuild\Release\bin\
Comment 1 Zoltan Arvai 2012-09-07 00:45:40 PDT
Created attachment 162694 [details]
patch

Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
Comment 2 WebKit Review Bot 2012-09-07 03:44:34 PDT
Comment on attachment 162694 [details]
patch

Clearing flags on attachment: 162694

Committed r127851: <http://trac.webkit.org/changeset/127851>
Comment 3 WebKit Review Bot 2012-09-07 03:44:38 PDT
All reviewed patches have been landed.  Closing bug.