Bug 96074 - [EFL][WK2] Minibrowser locks up when right clicking editable filed
Summary: [EFL][WK2] Minibrowser locks up when right clicking editable filed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks: 95955
  Show dependency treegraph
 
Reported: 2012-09-06 23:24 PDT by Jinwoo Song
Modified: 2012-09-09 19:33 PDT (History)
4 users (show)

See Also:


Attachments
patch (2.50 KB, patch)
2012-09-08 22:24 PDT, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-09-06 23:24:49 PDT
Minibrowser locks up when we click the input filed or text area with right mouse button.
Comment 1 Jinwoo Song 2012-09-08 22:24:04 PDT
Created attachment 162977 [details]
patch

WebProcess crashes when the context menu type is SubmenuType and non-CROSS_PLATFORM_CONTEXT_MENUS is used.
It is because platformSubMenu() in the ContextMenuItemEfl.cpp returns null. This patch implements the setSubMenu()
and platformSubMenu() to set and return the subMenuItems.
Comment 2 Gyuyoung Kim 2012-09-09 19:23:24 PDT
Comment on attachment 162977 [details]
patch

Looks good to me because EFL port also uses Vector class for context menu item as chromium port.
Comment 3 WebKit Review Bot 2012-09-09 19:33:17 PDT
Comment on attachment 162977 [details]
patch

Clearing flags on attachment: 162977

Committed r128011: <http://trac.webkit.org/changeset/128011>
Comment 4 WebKit Review Bot 2012-09-09 19:33:21 PDT
All reviewed patches have been landed.  Closing bug.