Bug 96069 - [WK2][WTR] Unskip detached-stylesheet-without-wrapper.html test case.
Summary: [WK2][WTR] Unskip detached-stylesheet-without-wrapper.html test case.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 22:36 PDT by Kangil Han
Modified: 2012-09-07 12:15 PDT (History)
4 users (show)

See Also:

Attachments
patch (3.85 KB, patch)
2012-09-06 22:38 PDT, Kangil Han 		kenneth: commit-queue-
Details | Formatted Diff | Diff
patch (3.85 KB, patch)
2012-09-07 01:16 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
patch (3.84 KB, patch)
2012-09-07 01:25 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-09-06 22:36:14 PDT 
fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html test case has been passed on EFL layout test.
WebKit EFL doesn't have to skip this.
Comment 1 Kangil Han 2012-09-06 22:38:02 PDT 
Created attachment 162673 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2012-09-07 00:52:17 PDT 
Comment on attachment 162673 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162673&action=review

> LayoutTests/ChangeLog:4
> +        [WK2][WTR] Unskip detached-stylesheet-without-wrapper.html test case in EFL.
> +        https://bugs.webkit.org/show_bug.cgi?id=96069

The EFL here is confusing as ou are skipping this on multiple platforms. Apart from that it is fine
Comment 3 Kangil Han 2012-09-07 01:16:17 PDT 
Created attachment 162700 [details]
patch

How about this? :-)
Comment 4 Kenneth Rohde Christiansen 2012-09-07 01:18:20 PDT 
Comment on attachment 162700 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162700&action=review

> LayoutTests/ChangeLog:4
> +        [EFL][WK2][WTR] Unskip detached-stylesheet-without-wrapper.html test case.
> +        https://bugs.webkit.org/show_bug.cgi?id=96069

It should not have EFL prefix it is it not EFL only and it is not.
Comment 5 Kangil Han 2012-09-07 01:25:28 PDT 
Created attachment 162706 [details]
patch

I misunderstood your comment. :/
Try it again!
Comment 6 WebKit Review Bot 2012-09-07 12:15:07 PDT 
Comment on attachment 162706 [details]
patch

Clearing flags on attachment: 162706

Committed r127904: <http://trac.webkit.org/changeset/127904>
Comment 7 WebKit Review Bot 2012-09-07 12:15:11 PDT 
All reviewed patches have been landed.  Closing bug.