Bug 96068 - webkit.py gdb pretty printer can't print CString
Summary: webkit.py gdb pretty printer can't print CString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 22:25 PDT by Kenichi Ishibashi
Modified: 2012-09-08 00:35 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.65 KB, patch)
2012-09-06 22:29 PDT, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff
Patch for landing (1.65 KB, patch)
2012-09-07 19:38 PDT, Kenichi Ishibashi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-09-06 22:25:30 PDT
Due to r126191.
Comment 1 Kenichi Ishibashi 2012-09-06 22:29:35 PDT
Created attachment 162671 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-09-06 22:30:21 PDT
Hi Tony,

Could you take a look?
Comment 3 Tony Chang 2012-09-07 09:53:46 PDT
Comment on attachment 162671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162671&action=review

> Tools/gdb/webkit.py:119
> +        data = self.val['m_buffer']['m_ptr']['m_data'].cast(gdb.lookup_type("char").pointer())

Nit: I would use ' instead of " to be consistent with the code around it.
Comment 4 Kenichi Ishibashi 2012-09-07 19:38:16 PDT
Created attachment 162934 [details]
Patch for landing
Comment 5 Kenichi Ishibashi 2012-09-07 19:38:39 PDT
Comment on attachment 162671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162671&action=review

>> Tools/gdb/webkit.py:119
>> +        data = self.val['m_buffer']['m_ptr']['m_data'].cast(gdb.lookup_type("char").pointer())
> 
> Nit: I would use ' instead of " to be consistent with the code around it.

Done. Thanks!
Comment 6 WebKit Review Bot 2012-09-08 00:35:55 PDT
Comment on attachment 162934 [details]
Patch for landing

Clearing flags on attachment: 162934

Committed r127965: <http://trac.webkit.org/changeset/127965>
Comment 7 WebKit Review Bot 2012-09-08 00:35:58 PDT
All reviewed patches have been landed.  Closing bug.