Bug 96064 - Add partial load test for PNG images with no alpha
Summary: Add partial load test for PNG images with no alpha
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL:
Keywords:
Depends on: 78239
Blocks: 97170
  Show dependency treegraph
 
Reported: 2012-09-06 21:39 PDT by noel gordon
Modified: 2012-09-21 01:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (402.21 KB, patch)
2012-09-06 23:35 PDT, noel gordon
no flags Details | Formatted Diff | Diff
Patch for landing (471.47 KB, patch)
2012-09-09 21:21 PDT, noel gordon
no flags Details | Formatted Diff | Diff
Patch (324.78 KB, patch)
2012-09-19 02:01 PDT, noel gordon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2012-09-06 21:39:08 PDT
Noticed a difference for partial loaded png images with no alpha on the mac port in bug 95707.  The image tag background is black on the mac port in that case; it should be blue.
Comment 1 noel gordon 2012-09-06 23:35:59 PDT
Created attachment 162681 [details]
Patch
Comment 2 noel gordon 2012-09-09 21:08:45 PDT
(In reply to comment #0)
> ... case; it should be blue.

ahem, it should be green.
Comment 3 noel gordon 2012-09-09 21:21:38 PDT
Created attachment 163034 [details]
Patch for landing
Comment 4 noel gordon 2012-09-19 02:01:52 PDT
Created attachment 164692 [details]
Patch
Comment 5 noel gordon 2012-09-19 17:58:35 PDT
Review please?
Comment 6 Simon Fraser (smfr) 2012-09-19 18:04:09 PDT
You need to make the patch review? if you want one.
Comment 7 WebKit Review Bot 2012-09-19 21:27:28 PDT
Comment on attachment 164692 [details]
Patch

Clearing flags on attachment: 164692

Committed r129088: <http://trac.webkit.org/changeset/129088>
Comment 8 WebKit Review Bot 2012-09-19 21:27:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Alexey Proskuryakov 2012-09-20 10:05:34 PDT
This change added an old syntax entry to platform/mac/TestExpectations at least. Please fix.
Comment 10 noel gordon 2012-09-20 19:58:49 PDT
http://trac.webkit.org/changeset/129187