There is a port specific file in each port which uses CMake except for wince port. So, I think it is better to remove GCActivityCallback.cpp in JavaScriptCore/CMakeLists.txt, then PlatformXXX.cmake file has a port specific file.
Created attachment 177935 [details] Work-in-progress
Created attachment 181281 [details] WIP
Comment on attachment 181281 [details] WIP Attachment 181281 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15677103
Created attachment 182275 [details] Patch
Comment on attachment 182275 [details] Patch Attachment 182275 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15810203
Created attachment 182703 [details] Patch for win port
CC'ing Geoffrey and Simon, I would like get you guys comment.
The only port-specific code here is the timer code. If we're going to refactor this to better fit the ports system, then I think we should rename "DefaultGCActivityCallback" to "GCActivityCallback", move SharedTimer into WTF, and build GCActivityCallback on top of SharedTimer. I don't understand the advantage of this refactoring, and I don't like adding the *None.cpp variant.
(In reply to comment #8) > The only port-specific code here is the timer code. If we're going to refactor this to better fit the ports system, then I think we should rename "DefaultGCActivityCallback" to "GCActivityCallback", move SharedTimer into WTF, and build GCActivityCallback on top of SharedTimer. > > I don't understand the advantage of this refactoring, and I don't like adding the *None.cpp variant. Ok, I will prepare new patch according to your comment. Thanks.
I'd like to postpone to fix this later.