Bug 96045 - [JSC] Split GCActivitiyCallback.cpp into each port file
Summary: [JSC] Split GCActivitiyCallback.cpp into each port file
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 95923
  Show dependency treegraph
 
Reported: 2012-09-06 17:42 PDT by Gyuyoung Kim
Modified: 2013-05-22 19:26 PDT (History)
6 users (show)

See Also:


Attachments
Work-in-progress (12.80 KB, patch)
2012-12-05 22:18 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
WIP (14.25 KB, patch)
2013-01-04 00:56 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (22.26 KB, patch)
2013-01-11 00:03 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for win port (22.33 KB, patch)
2013-01-14 22:15 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-09-06 17:42:41 PDT
There is a port specific file in each port which uses CMake except for wince port. So, I think it is better to remove GCActivityCallback.cpp in JavaScriptCore/CMakeLists.txt, then PlatformXXX.cmake file has a port specific file.
Comment 1 Gyuyoung Kim 2012-12-05 22:18:10 PST
Created attachment 177935 [details]
Work-in-progress
Comment 2 Gyuyoung Kim 2013-01-04 00:56:52 PST
Created attachment 181281 [details]
WIP
Comment 3 Build Bot 2013-01-04 01:39:40 PST
Comment on attachment 181281 [details]
WIP

Attachment 181281 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15677103
Comment 4 Gyuyoung Kim 2013-01-11 00:03:10 PST
Created attachment 182275 [details]
Patch
Comment 5 Build Bot 2013-01-11 00:25:45 PST
Comment on attachment 182275 [details]
Patch

Attachment 182275 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/15810203
Comment 6 Gyuyoung Kim 2013-01-14 22:15:08 PST
Created attachment 182703 [details]
Patch for win port
Comment 7 Gyuyoung Kim 2013-01-15 02:47:09 PST
CC'ing Geoffrey and Simon, I would like get you guys comment.
Comment 8 Geoffrey Garen 2013-01-16 19:04:01 PST
The only port-specific code here is the timer code. If we're going to refactor this to better fit the ports system, then I think we should rename "DefaultGCActivityCallback" to "GCActivityCallback", move SharedTimer into WTF, and build GCActivityCallback on top of SharedTimer.

I don't understand the advantage of this refactoring, and I don't like adding the *None.cpp variant.
Comment 9 Gyuyoung Kim 2013-01-19 03:59:12 PST
(In reply to comment #8)
> The only port-specific code here is the timer code. If we're going to refactor this to better fit the ports system, then I think we should rename "DefaultGCActivityCallback" to "GCActivityCallback", move SharedTimer into WTF, and build GCActivityCallback on top of SharedTimer.
> 
> I don't understand the advantage of this refactoring, and I don't like adding the *None.cpp variant.

Ok, I will prepare new patch according to your comment. Thanks.
Comment 10 Gyuyoung Kim 2013-05-22 19:26:12 PDT
I'd like to postpone to fix this later.