Bug 96043 - Combine MarkStack and SlotVisitor into single class
Summary: Combine MarkStack and SlotVisitor into single class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 17:16 PDT by Mark Hahnenberg
Modified: 2012-09-10 11:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (64.24 KB, patch)
2012-09-06 17:31 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (65.00 KB, patch)
2012-09-06 18:08 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff
Patch (65.05 KB, patch)
2012-09-06 20:34 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-09-06 17:16:56 PDT
MarkStack and SlotVisitor are pretty much the same thing. We should combine them to make the GC code slightly more sane.
Comment 1 Mark Hahnenberg 2012-09-06 17:31:47 PDT
Created attachment 162629 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-06 17:33:21 PDT
Attachment 162629 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/heap/SlotVisitor.cpp:172:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2012-09-06 17:33:40 PDT
Comment on attachment 162629 [details]
Patch

r=me
Comment 4 Mark Hahnenberg 2012-09-06 18:08:06 PDT
Created attachment 162635 [details]
Patch
Comment 5 WebKit Review Bot 2012-09-06 18:09:46 PDT
Attachment 162635 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/heap/SlotVisitor.cpp:172:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Build Bot 2012-09-06 19:06:45 PDT
Comment on attachment 162635 [details]
Patch

Attachment 162635 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13769574
Comment 7 Mark Hahnenberg 2012-09-06 20:34:18 PDT
Created attachment 162661 [details]
Patch
Comment 8 WebKit Review Bot 2012-09-06 20:37:40 PDT
Attachment 162661 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/heap/SlotVisitor.cpp:172:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Mark Hahnenberg 2012-09-10 11:40:46 PDT
Committed r128084: <http://trac.webkit.org/changeset/128084>