RESOLVED INVALID Bug 96040
Web Inspector: Allow extensions to open FilteredItemSelectorDialog 
https://bugs.webkit.org/show_bug.cgi?id=96040
Summary Web Inspector: Allow extensions to open FilteredItemSelectorDialog
johnjbarton
Reported 2012-09-06 16:46:26 PDT
The FilteredItemSelectorDialog (bound to eg control + o to open files) is a nice, general purpose list selection widget. By exposing it to WebInspector extensions, the extensions can be more effective, feel more integrated with the WebInspector, and users can adapt to extensions more quickly. Such an extension could have many uses, eg "find a CSS selector", "find a JS identifier", "find localized strings", "find test cases on my special test server", etc.
Attachments
Patch (17.94 KB, patch)
2012-09-06 17:06 PDT, johnjbarton 		no flags
DetailsFormatted DiffDiff
rebase and fix formatting (17.63 KB, patch)
2012-09-11 09:53 PDT, johnjbarton 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
johnjbarton
Comment 1 2012-09-06 17:06:01 PDT
Created attachment 162620 [details] Patch
johnjbarton
Comment 2 2012-09-06 17:07:17 PDT
Please give feedback on the concept and API first. I guess this will need to be behind some experimental flag.
WebKit Review Bot
Comment 3 2012-09-07 13:57:06 PDT
Comment on attachment 162620 [details] Patch Attachment 162620 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13778738 New failing tests: inspector/extensions/extensions-panel.html
johnjbarton
Comment 4 2012-09-11 09:53:51 PDT
Created attachment 163388 [details] rebase and fix formatting
WebKit Review Bot
Comment 5 2012-09-12 01:14:02 PDT
Comment on attachment 163388 [details] rebase and fix formatting Attachment 163388 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13825524 New failing tests: inspector/extensions/extensions-panel.html
Pavel Feldman
Comment 6 2012-09-21 03:09:52 PDT
Do we have use cases for this API? Did any of the extensions try to create such a UI on their panel? I wouldn't want to expose provisional extensions APIs.
Pavel Feldman
Comment 7 2012-09-21 03:10:11 PDT
Comment on attachment 163388 [details] rebase and fix formatting Clearing r? while we are figuring out whether this is needed.
johnjbarton
Comment 8 2012-09-21 07:34:11 PDT
I'm using it in my extension, to load files into an editor in conjunction with Resource get/setContent.
Note You need to log in before you can comment on or make changes to this bug.