Add StringBuilder::appendNumber() and use it
Created attachment 162597 [details] Patch
Nice!
Comment on attachment 162597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162597&action=review Faster, or just cleaner? > Source/JavaScriptCore/API/JSContextRef.cpp:210 > + builder.append(':'); We really need to rename this appendChar or overload appendLiteral(char) instead so it's easier to tell that it's the "fast" version.
Comment on attachment 162597 [details] Patch Attachment 162597 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13796642
(In reply to comment #3) > (From update of attachment 162597 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162597&action=review > > Faster, or just cleaner? Since it does not create a StringImpl for every number and appends the content of a character buffer directly it is faster too. > > Source/JavaScriptCore/API/JSContextRef.cpp:210 > > + builder.append(':'); > > We really need to rename this appendChar or overload appendLiteral(char) instead so it's easier to tell that it's the "fast" version. I can do this in a follow up patch.
Created attachment 163017 [details] Patch
(In reply to comment #5) > (In reply to comment #3) > > > Source/JavaScriptCore/API/JSContextRef.cpp:210 > > > + builder.append(':'); > > > > We really need to rename this appendChar or overload appendLiteral(char) instead so it's easier to tell that it's the "fast" version. > > I can do this in a follow up patch. yes. :) I certainly wan't expecting such in this patch. THanks!
Comment on attachment 163017 [details] Patch LGTM if the EWSes think so.
Comment on attachment 163017 [details] Patch Clearing flags on attachment: 163017 Committed r128014: <http://trac.webkit.org/changeset/128014>
All reviewed patches have been landed. Closing bug.