Bug 96029 - StringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents
Summary: StringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 14:50 PDT by Michael Saboff
Modified: 2012-09-06 21:48 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2012-09-06 15:15 PDT, Michael Saboff
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-09-06 14:50:24 PDT
For the case where a StringBuild is partially populated with 8 bit data, when toAtomicString() is called, it will convert the string unnecessarily to 16 bits.
Comment 1 Michael Saboff 2012-09-06 15:15:16 PDT
Created attachment 162600 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-06 21:48:01 PDT
Comment on attachment 162600 [details]
Patch

Clearing flags on attachment: 162600

Committed r127821: <http://trac.webkit.org/changeset/127821>
Comment 3 WebKit Review Bot 2012-09-06 21:48:04 PDT
All reviewed patches have been landed.  Closing bug.