Bug 96027 - [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
Summary: [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Major
Assignee: Max Feil
Depends on:
Reported: 2012-09-06 14:39 PDT by Max Feil
Modified: 2012-11-02 12:51 PDT (History)
3 users (show)

See Also:

Patch (2.05 KB, patch)
2012-09-06 14:47 PDT, Max Feil
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Feil 2012-09-06 14:39:43 PDT
The changes for https://bugs.webkit.org/show_bug.cgi?id=87337 (landed as http://svn.webkit.org/repository/webkit/trunk@119119) introduced a bug. The same conditions are not checked on enter fullscreen vs. exit.

Web sites such as http://videojs.com and youtube's mobile HTML5 player make the div container of the video element go fullscreen. This is allowed in WebPagePrivate::enterFullScreenForElement() but disallowed in WebPagePrivate::exitFullScreenForElement().

I am fixing this by allowing containers of video elements to exit fullscreen.
Comment 1 Max Feil 2012-09-06 14:47:53 PDT
Created attachment 162593 [details]
Comment 2 WebKit Review Bot 2012-09-08 21:28:56 PDT
Comment on attachment 162593 [details]

Clearing flags on attachment: 162593

Committed r127975: <http://trac.webkit.org/changeset/127975>
Comment 3 WebKit Review Bot 2012-09-08 21:29:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Max Feil 2012-11-02 12:51:41 PDT
Closing bug for patch that landed a long time ago.