Bug 96017 - Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
Summary: Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 13:32 PDT by Simon Fraser (smfr)
Modified: 2012-09-06 23:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.35 KB, patch)
2012-09-06 13:47 PDT, Simon Fraser (smfr) 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2012-09-06 13:32:28 PDT 
Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
Comment 1 Simon Fraser (smfr) 2012-09-06 13:47:22 PDT 
Created attachment 162574 [details]
Patch
Comment 2 James Robinson 2012-09-06 13:52:43 PDT 
Comment on attachment 162574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162574&action=review

> Source/WebCore/page/FrameView.h:-200
> -    // This includes position:fixed and sticky objects.

This comment was nice - I'm not sure if "viewport constrained" has quite caught on enough for everyone to know that it includes position:fixed and position:sticky
Comment 3 Simon Fraser (smfr) 2012-09-06 14:04:17 PDT 
http://trac.webkit.org/changeset/127783
Comment 4 Csaba Osztrogonác 2012-09-06 21:27:19 PDT 
(In reply to comment #3)
> http://trac.webkit.org/changeset/127783

And WK2 buildfix landed in https://trac.webkit.org/changeset/127816

Will you wait for the EWS and/or watch the buildbots next time, please?

Breaking the build and leaving it broken for 7 hours / 32 revisions isn't
too friendly ... I don't have to fix the build instead of you ... But 
you have to guarantee that your change builds everywhere. I might 
rollout the patch next time and let you fix it yourself.


Plese rescpect the following rule in the future:
https://www.webkit.org/coding/contributing.html
"Keeping the tree green
...
Your change must at least compile on all platforms."
Comment 5 Simon Fraser (smfr) 2012-09-06 23:18:56 PDT 
Thanks for the fix, Ossy. Sorry for the bustage.