RESOLVED FIXED Bug 96017
Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView 
https://bugs.webkit.org/show_bug.cgi?id=96017
Summary Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
Simon Fraser (smfr)
Reported 2012-09-06 13:32:28 PDT
Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
Attachments
Patch (15.35 KB, patch)
2012-09-06 13:47 PDT, Simon Fraser (smfr) 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-09-06 13:47:22 PDT
Created attachment 162574 [details] Patch
James Robinson
Comment 2 2012-09-06 13:52:43 PDT
Comment on attachment 162574 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162574&action=review > Source/WebCore/page/FrameView.h:-200 > - // This includes position:fixed and sticky objects. This comment was nice - I'm not sure if "viewport constrained" has quite caught on enough for everyone to know that it includes position:fixed and position:sticky
Simon Fraser (smfr)
Comment 3 2012-09-06 14:04:17 PDT
http://trac.webkit.org/changeset/127783
Csaba Osztrogonác
Comment 4 2012-09-06 21:27:19 PDT
(In reply to comment #3) > http://trac.webkit.org/changeset/127783 And WK2 buildfix landed in https://trac.webkit.org/changeset/127816 Will you wait for the EWS and/or watch the buildbots next time, please? Breaking the build and leaving it broken for 7 hours / 32 revisions isn't too friendly ... I don't have to fix the build instead of you ... But you have to guarantee that your change builds everywhere. I might rollout the patch next time and let you fix it yourself. Plese rescpect the following rule in the future: https://www.webkit.org/coding/contributing.html "Keeping the tree green ... Your change must at least compile on all platforms."
Simon Fraser (smfr)
Comment 5 2012-09-06 23:18:56 PDT
Thanks for the fix, Ossy. Sorry for the bustage.
Note You need to log in before you can comment on or make changes to this bug.