Bug 96011 - [BlackBerry] Initialize caret rectangle with invalid location
Summary: [BlackBerry] Initialize caret rectangle with invalid location
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 13:00 PDT by Yongxin Dai
Modified: 2012-09-07 11:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.06 KB, patch)
2012-09-06 13:42 PDT, Yongxin Dai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongxin Dai 2012-09-06 13:00:46 PDT
In SelectionHandler::selectionPositionChanged() method, startCaret and endCaret are used to notify clients about new caret positions. We should initialize startCaret and endCaret with location(-1. -1), and keep them empty before they are assigned to valid values.  This would help for other classes to check validity of the caret correctly.
Comment 1 Yongxin Dai 2012-09-06 13:42:44 PDT
Created attachment 162573 [details]
Patch
Comment 2 Rob Buis 2012-09-07 10:13:20 PDT
Comment on attachment 162573 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2012-09-07 11:10:55 PDT
Comment on attachment 162573 [details]
Patch

Clearing flags on attachment: 162573

Committed r127894: <http://trac.webkit.org/changeset/127894>
Comment 4 WebKit Review Bot 2012-09-07 11:10:57 PDT
All reviewed patches have been landed.  Closing bug.