Bug 96000 - Make RenderingAllInOne.cpp usable for ports other than Apple/Win
Summary: Make RenderingAllInOne.cpp usable for ports other than Apple/Win
Status: RESOLVED DUPLICATE of bug 99579
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 11:04 PDT by Simon Hausmann
Modified: 2015-02-26 04:45 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.54 KB, patch)
2012-09-06 11:06 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (3.50 KB, patch)
2012-09-06 11:10 PDT, Simon Hausmann
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2012-09-06 11:04:02 PDT
Make RenderingAllInOne.cpp usable for ports other than Apple/Win
Comment 1 Simon Hausmann 2012-09-06 11:06:03 PDT
Created attachment 162539 [details]
Patch
Comment 2 Simon Hausmann 2012-09-06 11:10:32 PDT
Created attachment 162540 [details]
Patch

Rebased to ToT
Comment 3 Simon Hausmann 2012-09-06 11:13:38 PDT
An alternative is to put #ifdefs into the AllInOne cpp files, although that would complicate things for the Qt build system.

Of course if those files are not meant to be shareable across ports, then that's also okay, wouldn't be a big deal I think.
Comment 4 Simon Hausmann 2012-09-21 13:16:27 PDT
Reverted r129248 for reason:

Broke win build

Committed r129249: <http://trac.webkit.org/changeset/129249>
Comment 5 Csaba Osztrogonác 2015-02-26 04:45:01 PST

*** This bug has been marked as a duplicate of bug 99579 ***