Bug 95990 – [EFL][WK2] Build warning : fix warning about extended initializer on EWK2UnitTestBase.cpp.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Byungwoo Lee]

There is a warning on EWK2UnitTestBase.cpp.

[Byungwoo Lee]

Warning message : warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x [enabled by default]

[Byungwoo Lee]

Created attachment 162522 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 162522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162522&action=review

> Source/WebKit2/ChangeLog:3
> +        Build warning : fix warning about extended initializer lists on EWK2UnitTestBase.cpp.

Good to add [EFL][WK2]

[Byungwoo Lee]

Created attachment 162680 [details]
Patch

[Ryuan Choi]

Comment on attachment 162680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44
> +    static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View");
> +    return ewkViewClass;

Did you test whether this is fine although test cases does not clear the methods ?

[Byungwoo Lee]

(In reply to comment #5)
> (From update of attachment 162680 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44
> > +    static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View");
> > +    return ewkViewClass;
> 
> Did you test whether this is fine although test cases does not clear the methods ?

It's a good point. There was no regression with current test case.
But there can be some problem because ewk2UnitTestBrowserViewSmartClass() returns reference. (The initial data can be changed.)

Return by copying data will be better.

Thanks for pointing this.

[Byungwoo Lee]

Created attachment 162707 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 162707 [details]
Patch

LGTM.

[Gyuyoung Kim]

Comment on attachment 162707 [details]
Patch

Looks fine.

[WebKit Review Bot]

Comment on attachment 162707 [details]
Patch

Clearing flags on attachment: 162707

Committed r128145: <http://trac.webkit.org/changeset/128145>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.