Bug 95990 - [EFL][WK2] Build warning : fix warning about extended initializer on EWK2UnitTestBase.cpp.
Summary: [EFL][WK2] Build warning : fix warning about extended initializer on EWK2Unit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 09:14 PDT by Byungwoo Lee
Modified: 2012-09-10 22:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2012-09-06 09:20 PDT, Byungwoo Lee 		no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2012-09-06 23:18 PDT, Byungwoo Lee 		no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2012-09-07 01:40 PDT, Byungwoo Lee 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Byungwoo Lee 2012-09-06 09:14:06 PDT 
There is a warning on EWK2UnitTestBase.cpp.
Comment 1 Byungwoo Lee 2012-09-06 09:17:57 PDT 
Warning message : warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x [enabled by default]
Comment 2 Byungwoo Lee 2012-09-06 09:20:57 PDT 
Created attachment 162522 [details]
Patch
Comment 3 Gyuyoung Kim 2012-09-06 22:47:17 PDT 
Comment on attachment 162522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162522&action=review

> Source/WebKit2/ChangeLog:3
> +        Build warning : fix warning about extended initializer lists on EWK2UnitTestBase.cpp.

Good to add [EFL][WK2]
Comment 4 Byungwoo Lee 2012-09-06 23:18:07 PDT 
Created attachment 162680 [details]
Patch
Comment 5 Ryuan Choi 2012-09-06 23:25:30 PDT 
Comment on attachment 162680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review

> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44
> +    static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View");
> +    return ewkViewClass;

Did you test whether this is fine although test cases does not clear the methods ?
Comment 6 Byungwoo Lee 2012-09-07 01:01:17 PDT 
(In reply to comment #5)
> (From update of attachment 162680 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=162680&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:44
> > +    static Ewk_View_Smart_Class ewkViewClass = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("Browser_View");
> > +    return ewkViewClass;
> 
> Did you test whether this is fine although test cases does not clear the methods ?

It's a good point. There was no regression with current test case.
But there can be some problem because ewk2UnitTestBrowserViewSmartClass() returns reference. (The initial data can be changed.)

Return by copying data will be better.

Thanks for pointing this.
Comment 7 Byungwoo Lee 2012-09-07 01:40:28 PDT 
Created attachment 162707 [details]
Patch
Comment 8 Gyuyoung Kim 2012-09-07 02:02:02 PDT 
Comment on attachment 162707 [details]
Patch

LGTM.
Comment 9 Gyuyoung Kim 2012-09-10 21:40:48 PDT 
Comment on attachment 162707 [details]
Patch

Looks fine.
Comment 10 WebKit Review Bot 2012-09-10 22:03:34 PDT 
Comment on attachment 162707 [details]
Patch

Clearing flags on attachment: 162707

Committed r128145: <http://trac.webkit.org/changeset/128145>
Comment 11 WebKit Review Bot 2012-09-10 22:03:38 PDT 
All reviewed patches have been landed.  Closing bug.