WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
95983
Web Inspector: Migrate Database to async protocol commands
https://bugs.webkit.org/show_bug.cgi?id=95983
Summary
Web Inspector: Migrate Database to async protocol commands
Vsevolod Vlasov
Reported
2012-09-06 07:50:31 PDT
Patch to follow.
Attachments
Patch
(22.92 KB, patch)
2012-09-06 08:13 PDT
,
Vsevolod Vlasov
no flags
Details
Formatted Diff
Diff
Patch
(22.95 KB, patch)
2012-09-06 10:05 PDT
,
Vsevolod Vlasov
no flags
Details
Formatted Diff
Diff
Patch
(22.96 KB, patch)
2012-09-07 01:50 PDT
,
Vsevolod Vlasov
apavlov
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1
2012-09-06 08:13:42 PDT
Created
attachment 162509
[details]
Patch
Build Bot
Comment 2
2012-09-06 08:22:02 PDT
Comment on
attachment 162509
[details]
Patch
Attachment 162509
[details]
did not pass mac-ews (mac): Output:
http://queues.webkit.org/results/13771360
Vsevolod Vlasov
Comment 3
2012-09-06 10:05:17 PDT
Created
attachment 162531
[details]
Patch
Vsevolod Vlasov
Comment 4
2012-09-07 01:50:38 PDT
Created
attachment 162710
[details]
Patch
Alexander Pavlov (apavlov)
Comment 5
2012-09-07 05:07:02 PDT
Comment on
attachment 162710
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=162710&action=review
> Source/WebCore/inspector/InspectorDatabaseAgent.cpp:284 > + UNUSED_PARAM(error);
Not necessary, just declare ...::executeSQL(ErrorString*, const String& databaseId,...)
Vsevolod Vlasov
Comment 6
2012-09-07 05:32:34 PDT
Committed
r127861
: <
http://trac.webkit.org/changeset/127861
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug