Bug 95983 - Web Inspector: Migrate Database to async protocol commands
Summary: Web Inspector: Migrate Database to async protocol commands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 07:50 PDT by Vsevolod Vlasov
Modified: 2012-09-07 05:32 PDT (History)
10 users (show)

See Also:

Attachments
Patch (22.92 KB, patch)
2012-09-06 08:13 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (22.95 KB, patch)
2012-09-06 10:05 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (22.96 KB, patch)
2012-09-07 01:50 PDT, Vsevolod Vlasov 		apavlov: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-09-06 07:50:31 PDT 
Patch to follow.
Comment 1 Vsevolod Vlasov 2012-09-06 08:13:42 PDT 
Created attachment 162509 [details]
Patch
Comment 2 Build Bot 2012-09-06 08:22:02 PDT 
Comment on attachment 162509 [details]
Patch

Attachment 162509 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13771360
Comment 3 Vsevolod Vlasov 2012-09-06 10:05:17 PDT 
Created attachment 162531 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-09-07 01:50:38 PDT 
Created attachment 162710 [details]
Patch
Comment 5 Alexander Pavlov (apavlov) 2012-09-07 05:07:02 PDT 
Comment on attachment 162710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=162710&action=review

> Source/WebCore/inspector/InspectorDatabaseAgent.cpp:284
> +    UNUSED_PARAM(error);

Not necessary, just declare ...::executeSQL(ErrorString*, const String& databaseId,...)
Comment 6 Vsevolod Vlasov 2012-09-07 05:32:34 PDT 
Committed r127861: <http://trac.webkit.org/changeset/127861>