Bug 95973 - [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
Summary: [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-06 04:29 PDT by Chris Dumez
Modified: 2012-09-06 07:35 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.08 KB, patch)
2012-09-06 04:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-06 04:29:21 PDT 
Currently EventSender in WebKitTestRunner unconditionally maps "addSelectionKey" to "Meta" modifier. This is fine on Mac but on others OSes, it should be mapped to "Control" instead.

This is causing the following test cases to fail for WebKit2 on non-Mac:
  fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html
  fast/forms/listbox-deselect-scroll.html
  fast/forms/listbox-selection.html
Comment 1 Chris Dumez 2012-09-06 04:38:29 PDT 
Created attachment 162475 [details]
Patch
Comment 2 Chris Dumez 2012-09-06 04:43:28 PDT 
Adding Ossy in CC since someone may want to check if the following tests can be unskipped on Qt with this fix:
  fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html
  fast/forms/listbox-deselect-scroll.html
  fast/forms/listbox-selection.html

They are skipped in the global Skipped list, not in the WK2-specific one so I did not dare unskip them on Qt.
Comment 3 WebKit Review Bot 2012-09-06 07:35:40 PDT 
Comment on attachment 162475 [details]
Patch

Clearing flags on attachment: 162475

Committed r127739: <http://trac.webkit.org/changeset/127739>
Comment 4 WebKit Review Bot 2012-09-06 07:35:45 PDT 
All reviewed patches have been landed.  Closing bug.