Bug 95969 - [Qt] Enable CSS Device Adaptation
Summary: [Qt] Enable CSS Device Adaptation
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on: 95959 102811
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-06 03:17 PDT by Thiago Marcos P. Santos
Modified: 2014-02-03 03:22 PST (History)
8 users (show)

See Also:


Attachments
Patch (6.31 KB, patch)
2012-11-26 08:39 PST, Thiago Marcos P. Santos
tmpsantos: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-09-06 03:17:50 PDT
Do that when the implementation is stable enough. Unskip layout tests that should pass.
Comment 1 Thiago Marcos P. Santos 2012-11-26 08:39:45 PST
Created attachment 176009 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-11-26 08:48:56 PST
CSS Device Adaptation relies on the same backend used by viewport meta, already supported by the Qt port.

The current implementation is passing 29/34 tests of the Opera test suite (being one failure a "orientation test" which is up to the port to implement). The pass rate is the same as EFL.

The nice thing about enabling this flag is it will start to test fixed layout on the WebKitTestRunner (I landed the bits for Qt support at the bug 102811). We have examples already of regressions on the EFL port that were only caught because we run these tests with a flickable viewport.

Now it is up to you guys.
Comment 3 Anders Carlsson 2013-10-02 21:17:33 PDT
Comment on attachment 176009 [details]
Patch

Qt has been removed, clearing review flags.
Comment 4 Jocelyn Turcotte 2014-02-03 03:22:29 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.