Bug 95966 - Expose DOM interface for CSS Device Adaptation
Summary: Expose DOM interface for CSS Device Adaptation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords: WebExposed
Depends on:
Blocks: 95959
  Show dependency tree / graph
 
Reported: 2012-09-06 03:12 PDT by Thiago Marcos P. Santos
Modified: 2012-11-23 00:07 PST (History)
19 users (show)

See Also:

Attachments
WIP (26.24 KB, patch)
2012-11-20 01:11 PST, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Patch (24.02 KB, patch)
2012-11-20 08:18 PST, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Patch (25.12 KB, patch)
2012-11-22 06:27 PST, Thiago Marcos P. Santos 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-09-06 03:12:04 PDT 
Add it for both V8 and JSC.
Comment 1 Thiago Marcos P. Santos 2012-11-20 01:11:58 PST 
Created attachment 175170 [details]
WIP

Build test (with the feature enabled by default on all the ports) to see if it the EWS explodes.
Comment 2 Adam Barth 2012-11-20 01:30:48 PST 
Comment on attachment 175170 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=175170&action=review

> Source/WebKit/chromium/features.gypi:45
> -      'ENABLE_CSS_DEVICE_ADAPTATION=0',
> +      'ENABLE_CSS_DEVICE_ADAPTATION=1',

I assume you don't plan to land this part of this patch.
Comment 3 Thiago Marcos P. Santos 2012-11-20 01:40:03 PST 
Comment on attachment 175170 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=175170&action=review

>> Source/WebKit/chromium/features.gypi:45
>> +      'ENABLE_CSS_DEVICE_ADAPTATION=1',
> 
> I assume you don't plan to land this part of this patch.

Nop, it is just a build test as I wrote on the comments. Just to make sure it will work on all the ports if they want to enable it one day.
Comment 4 Thiago Marcos P. Santos 2012-11-20 08:15:02 PST 
The build test failed on GTK but I could build it locally in a clean environment. I'm guessing that GTK buildsystem might have a problem on tracking dependencies when a flag affects CSSValueKeywords.in.
Comment 5 Thiago Marcos P. Santos 2012-11-20 08:18:05 PST 
Created attachment 175225 [details]
Patch
Comment 6 Thiago Marcos P. Santos 2012-11-22 06:27:30 PST 
Created attachment 175662 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-23 00:07:17 PST 
Comment on attachment 175662 [details]
Patch

Clearing flags on attachment: 175662

Committed r135564: <http://trac.webkit.org/changeset/135564>
Comment 8 WebKit Review Bot 2012-11-23 00:07:24 PST 
All reviewed patches have been landed.  Closing bug.