Add build time option to enable/disable CSS Device Adaptation support.
Created attachment 163701 [details] Patch
How does this compile-time flag relate to ENABLE_LEGACY_VIEWPORT_ADAPTION and ENABLE_VIEWPORT ?
(In reply to comment #2) > How does this compile-time flag relate to ENABLE_LEGACY_VIEWPORT_ADAPTION and ENABLE_VIEWPORT ? ENABLE_LEGACY_VIEWPORT_ADAPTION is unrelated. It just enables some extra keywords to the Viewport Meta Tag implementation. CSS Device Adaption shares code with Viewport Meta Tag, since it is basically a CSS equivalent of Meta Tag. The code ends at ChromeClient::dispatchViewportPropertiesDidChange which on Chromium (and AFAIK only Chromium) is protected by ENABLE_VIEWPORT. In this case, if Chromium wants CSS_DEVICE_ADAPTATION, it will also need to enable ENABLE_VIEWPORT.
Perhaps we should remove the ENABLE_VIEWPORT guards from dispatchViewportPropertiesDidChange in Chromium? In any case, that's an issue for a later patch. Once your implementation is complete, do you think it would make sense to merge this ENABLE with ENABLE_VIEWPORT?
(In reply to comment #4) > Perhaps we should remove the ENABLE_VIEWPORT guards from dispatchViewportPropertiesDidChange in Chromium? In any case, that's an issue for a later patch. > > Once your implementation is complete, do you think it would make sense to merge this ENABLE with ENABLE_VIEWPORT? Makes a lot of sense. From the ChromeClient point of view, they are the same thing.
Comment on attachment 163701 [details] Patch r=me but only land if the feature was agreed upon on webkit-dev
Created attachment 170845 [details] Patch
Comment on attachment 170845 [details] Patch Clearing flags on attachment: 170845 Committed r132600: <http://trac.webkit.org/changeset/132600>
All reviewed patches have been landed. Closing bug.