EOM
Created attachment 162459 [details] Patch
Comment on attachment 162459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162459&action=review > Source/WebCore/dom/MemoryInstrumentation.cpp:40 > +MemoryObjectType GenericMemoryTypes::OwnersTypePlaceholder = "OwnersTypePlaceholder"; The new name is too verbose and still sounds unclear to me, I'd rather leave it as Other or passed 0 where the Other is used since we should never report types with such type anyways. > Source/WebCore/dom/MemoryInstrumentation.cpp:42 > +MemoryObjectType WebCoreMemoryTypes::DOMTree = "DOMTree"; DOMTree -> Page ? > Source/WebCore/dom/MemoryInstrumentation.cpp:50 > +MemoryObjectType WebCoreMemoryTypes::CachedResource = "MemoryCache.RawResource"; CachedResource -> CachedResourceRaw
Created attachment 162486 [details] Patch
Created attachment 162487 [details] Patch
Comment on attachment 162487 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162487&action=review > Source/WebCore/loader/cache/CachedResource.cpp:806 > + MemoryClassInfo info(memoryObjectInfo, this, GenericMemoryTypes::Undefined); There may be instances of the CachedResource class(that are not descendants).
Created attachment 162489 [details] Patch
(In reply to comment #5) > (From update of attachment 162487 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162487&action=review > > > Source/WebCore/loader/cache/CachedResource.cpp:806 > > + MemoryClassInfo info(memoryObjectInfo, this, GenericMemoryTypes::Undefined); > > There may be instances of the CachedResource class(that are not descendants). done
Committed r127738: <http://trac.webkit.org/changeset/127738>
(In reply to comment #8) > Committed r127738: <http://trac.webkit.org/changeset/127738> It caused a regression - https://bugs.webkit.org/show_bug.cgi?id=95988 Could you check it, please?
(In reply to comment #9) > (In reply to comment #8) > > Committed r127738: <http://trac.webkit.org/changeset/127738> > > It caused a regression - https://bugs.webkit.org/show_bug.cgi?id=95988 > Could you check it, please? the fix is landed as r127744